[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH 6/7] qcow2: aio support for compres
From: |
Alberto Garcia |
Subject: |
Re: [Qemu-devel] [Qemu-block] [PATCH 6/7] qcow2: aio support for compressed cluster read |
Date: |
Tue, 06 Nov 2018 16:06:41 +0100 |
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Thu 01 Nov 2018 07:27:37 PM CET, Vladimir Sementsov-Ogievskiy wrote:
> + buf = g_try_malloc(csize);
> + if (!buf) {
> + return -ENOMEM;
> + }
> + iov.iov_base = buf;
> + iov.iov_len = csize;
> + qemu_iovec_init_external(&local_qiov, &iov, 1);
>
> - iov.iov_base = s->cluster_data;
> - iov.iov_len = csize;
> - qemu_iovec_init_external(&local_qiov, &iov, 1);
> + out_buf = qemu_blockalign(bs, s->cluster_size);
You should also check whether out_buf is NULL, shouldn't you?
Berto
- [Qemu-devel] [PATCH 2/7] qcow2: make more generic interface for qcow2_compress, (continued)
- [Qemu-devel] [PATCH 2/7] qcow2: make more generic interface for qcow2_compress, Vladimir Sementsov-Ogievskiy, 2018/11/01
- [Qemu-devel] [PATCH 3/7] qcow2: move decompression from qcow2-cluster.c to qcow2.c, Vladimir Sementsov-Ogievskiy, 2018/11/01
- [Qemu-devel] [PATCH 1/7] qcow2: use Z_OK instead of 0 for deflateInit2 return code check, Vladimir Sementsov-Ogievskiy, 2018/11/01
- [Qemu-devel] [PATCH 7/7] qcow2: do decompression in threads, Vladimir Sementsov-Ogievskiy, 2018/11/01
- [Qemu-devel] [PATCH 6/7] qcow2: aio support for compressed cluster read, Vladimir Sementsov-Ogievskiy, 2018/11/01
- Re: [Qemu-devel] [Qemu-block] [PATCH 6/7] qcow2: aio support for compressed cluster read,
Alberto Garcia <=
Re: [Qemu-devel] [PATCH 0/7] qcow2 decompress in threads, Kevin Wolf, 2018/11/12