qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [Qemu-block] [PATCH 6/7] qcow2: aio support for compres


From: Alberto Garcia
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 6/7] qcow2: aio support for compressed cluster read
Date: Tue, 06 Nov 2018 16:06:41 +0100
User-agent: Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu)

On Thu 01 Nov 2018 07:27:37 PM CET, Vladimir Sementsov-Ogievskiy wrote:

> +    buf = g_try_malloc(csize);
> +    if (!buf) {
> +        return -ENOMEM;
> +    }
> +    iov.iov_base = buf;
> +    iov.iov_len = csize;
> +    qemu_iovec_init_external(&local_qiov, &iov, 1);
>  
> -        iov.iov_base = s->cluster_data;
> -        iov.iov_len = csize;
> -        qemu_iovec_init_external(&local_qiov, &iov, 1);
> +    out_buf = qemu_blockalign(bs, s->cluster_size);

You should also check whether out_buf is NULL, shouldn't you?

Berto



reply via email to

[Prev in Thread] Current Thread [Next in Thread]