[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 02/10] hw/m68k: implement ADB bus support for
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH v6 02/10] hw/m68k: implement ADB bus support for via |
Date: |
Tue, 6 Nov 2018 15:59:47 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 2018-11-02 16:22, Mark Cave-Ayland wrote:
> From: Laurent Vivier <address@hidden>
>
> Co-developed-by: Mark Cave-Ayland <address@hidden>
> Signed-off-by: Mark Cave-Ayland <address@hidden>
> Signed-off-by: Laurent Vivier <address@hidden>
> Reviewed-by: Hervé Poussineau <address@hidden>
> ---
> hw/misc/mac_via.c | 190
> ++++++++++++++++++++++++++++++++++++++++++++++
> include/hw/misc/mac_via.h | 7 ++
> 2 files changed, 197 insertions(+)
Looks ok to me at a quick glance now (can't say much about the details
since I don't know the ADB stuff at all), so FWIW, a weak:
Reviewed-by: Thomas Huth <address@hidden>
- [Qemu-devel] [PATCH v6 00/10] hw/m68k: add Apple Machintosh Quadra 800 machine, Mark Cave-Ayland, 2018/11/02
- [Qemu-devel] [PATCH v6 01/10] hw/m68k: add via support, Mark Cave-Ayland, 2018/11/02
- [Qemu-devel] [PATCH v6 02/10] hw/m68k: implement ADB bus support for via, Mark Cave-Ayland, 2018/11/02
- Re: [Qemu-devel] [PATCH v6 02/10] hw/m68k: implement ADB bus support for via,
Thomas Huth <=
- [Qemu-devel] [PATCH v6 03/10] escc: introduce a selector for the register bit, Mark Cave-Ayland, 2018/11/02
- [Qemu-devel] [PATCH v6 07/10] hw/m68k: add Nubus support for macfb video card, Mark Cave-Ayland, 2018/11/02
- [Qemu-devel] [PATCH v6 06/10] hw/m68k: add Nubus support, Mark Cave-Ayland, 2018/11/02
- [Qemu-devel] [PATCH v6 04/10] hw/m68k: add macfb video card, Mark Cave-Ayland, 2018/11/02
- [Qemu-devel] [PATCH v6 05/10] esp: add pseudo-DMA as used by Macintosh, Mark Cave-Ayland, 2018/11/02
- [Qemu-devel] [PATCH v6 08/10] hw/m68k: add a dummy SWIM floppy controller, Mark Cave-Ayland, 2018/11/02
- [Qemu-devel] [PATCH v6 09/10] dp8393x: manage big endian bus, Mark Cave-Ayland, 2018/11/02
- [Qemu-devel] [PATCH v6 10/10] hw/m68k: define Macintosh Quadra 800, Mark Cave-Ayland, 2018/11/02