[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 05/33] virtio-blk: fix comment for virtio_blk_rw_
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PULL 05/33] virtio-blk: fix comment for virtio_blk_rw_complete |
Date: |
Mon, 5 Nov 2018 22:44:01 -0500 |
On Tue, Nov 06, 2018 at 11:17:03AM +0800, Dongli Zhang wrote:
>
>
> On 11/06/2018 02:15 AM, Michael S. Tsirkin wrote:
> > From: Yaowei Bai <address@hidden>
> >
> > Here should be submit_requests, there is no submit_merged_requests
> > function.
> >
> > Signed-off-by: Yaowei Bai <address@hidden>
> > Reviewed-by: Michael S. Tsirkin <address@hidden>
> > Signed-off-by: Michael S. Tsirkin <address@hidden>
> > ---
> > hw/block/virtio-blk.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
> > index 225fe44b7a..83cf5c01f9 100644
> > --- a/hw/block/virtio-blk.c
> > +++ b/hw/block/virtio-blk.c
> > @@ -97,8 +97,8 @@ static void virtio_blk_rw_complete(void *opaque, int ret)
> >
> > if (req->qiov.nalloc != -1) {
> > /* If nalloc is != 1 req->qiov is a local copy of the original
>
> Should it be "If nalloc is != -1" in the comment? Seems the initial state is
> -1.
Makes sense. Patch?
> > - * external iovec. It was allocated in submit_merged_requests
> > - * to be able to merge requests. */
> > + * external iovec. It was allocated in submit_requests to be
> > + * able to merge requests. */
> > qemu_iovec_destroy(&req->qiov);
> > }
> >
> >
>
> Dongli Zhang
- Re: [Qemu-devel] [PULL 02/33] tests: Move tests/hex-loader-check-data/ to tests/data/hex-loader/, (continued)
[Qemu-devel] [PULL 01/33] tests: Move tests/acpi-test-data/ to tests/data/acpi/, Michael S. Tsirkin, 2018/11/05
[Qemu-devel] [PULL 03/33] configure: Rename FILES variable to LINKS, Michael S. Tsirkin, 2018/11/05
[Qemu-devel] [PULL 04/33] configure: Use LINKS loop for all build tree symlinks, Michael S. Tsirkin, 2018/11/05
[Qemu-devel] [PULL 06/33] intel_iommu: introduce vtd_reset_caches(), Michael S. Tsirkin, 2018/11/05
[Qemu-devel] [PULL 05/33] virtio-blk: fix comment for virtio_blk_rw_complete, Michael S. Tsirkin, 2018/11/05
[Qemu-devel] [PULL 07/33] intel_iommu: better handling of dmar state switch, Michael S. Tsirkin, 2018/11/05
[Qemu-devel] [PULL 08/33] intel_iommu: move ce fetching out when sync shadow, Michael S. Tsirkin, 2018/11/05
[Qemu-devel] [PULL 09/33] intel_iommu: handle invalid ce for shadow sync, Michael S. Tsirkin, 2018/11/05
[Qemu-devel] [PULL 16/33] x86_iommu/amd: Add interrupt remap support when VAPIC is not enabled, Michael S. Tsirkin, 2018/11/05
[Qemu-devel] [PULL 13/33] x86_iommu/amd: remove V=1 check from amdvi_validate_dte(), Michael S. Tsirkin, 2018/11/05
[Qemu-devel] [PULL 18/33] x86_iommu/amd: Add interrupt remap support when VAPIC is enabled, Michael S. Tsirkin, 2018/11/05
[Qemu-devel] [PULL 14/33] x86_iommu/amd: make the address space naming consistent with intel-iommu, Michael S. Tsirkin, 2018/11/05
[Qemu-devel] [PULL 21/33] pci-testdev: add optional memory bar, Michael S. Tsirkin, 2018/11/05
[Qemu-devel] [PULL 10/33] vhost-user-blk: start vhost when guest kicks, Michael S. Tsirkin, 2018/11/05
[Qemu-devel] [PULL 11/33] x86_iommu: move the kernel-irqchip check in common code, Michael S. Tsirkin, 2018/11/05