Re: [Qemu-devel] [PATCH v3 6/8] pc-testdev: use HTTPS git URL

[Philippe Mathieu-Daudé]

On 4/11/18 12:24, Stefan Hajnoczi wrote:
> When you clone the repository without previous commit history, 'git://'
> doesn't protect from man-in-the-middle attacks.  HTTPS is more secure
> since the client verifies the server certificate.
>
> Cc: Paolo Bonzini <address@hidden>
> Suggested-by: Eric Blake <address@hidden>
> Signed-off-by: Stefan Hajnoczi <address@hidden>

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>

> ---
>   hw/misc/pc-testdev.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/misc/pc-testdev.c b/hw/misc/pc-testdev.c
> index 697eb88c97..0aee04f231 100644
> --- a/hw/misc/pc-testdev.c
> +++ b/hw/misc/pc-testdev.c
> @@ -32,7 +32,7 @@
>    * -kernel /home/lmr/Code/virt-test.git/kvm/unittests/msr.flat
>    *
>    * Where msr.flat is one of the KVM unittests, present on a separate repo,
> - * git://git.kernel.org/pub/scm/virt/kvm/kvm-unit-tests.git
> + * https://git.kernel.org/pub/scm/virt/kvm/kvm-unit-tests.git
>   */
>   
>   #include "qemu/osdep.h"