|
| From: | Richard Henderson |
| Subject: | Re: [Qemu-devel] [PATCH 1/2] target/mips: Fix decoding mechanism of R5900 MFLO1, MFHI1, MTLO1 and MTHI1 |
| Date: | Sun, 4 Nov 2018 10:15:51 +0000 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 |
On 11/2/18 4:08 PM, Fredrik Noring wrote:
> + switch (opc) {
> + case TX79_MMI_MFHI1:
> +#if defined(TARGET_MIPS64)
> + tcg_gen_ext32s_tl(cpu_gpr[reg], cpu_HI[1]);
> +#else
> + tcg_gen_mov_tl(cpu_gpr[reg], cpu_HI[1]);
> +#endif
You do not need this ifdef. This is already done in tcg/tcg-op.h:
$ grep tcg_gen_ext32s_tl tcg/tcg-op.h
#define tcg_gen_ext32s_tl tcg_gen_ext32s_i64
#define tcg_gen_ext32s_tl tcg_gen_mov_i32
r~
| [Prev in Thread] | Current Thread | [Next in Thread] |