Re: [Qemu-devel] [PATCH 0/4] scsi-generic: fixes for Block Limits emulation

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH 0/4] scsi-generic: fixes for Block Limits emulation

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
425800699b scsi-generic: do not do VPD emulation for sense other than 
ILLEGAL_REQUEST
671b9514d6 scsi-generic: avoid invalid access to struct when emulating block 
limits
ead933fd34 scsi-generic: avoid out-of-bounds access to VPD page list
5477ca609f scsi-generic: keep VPD page list sorted

=== OUTPUT BEGIN ===
Checking PATCH 1/4: scsi-generic: keep VPD page list sorted...
Checking PATCH 2/4: scsi-generic: avoid out-of-bounds access to VPD page list...
Checking PATCH 3/4: scsi-generic: avoid invalid access to struct when emulating 
block limits...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#31: 
new file mode 100644

total: 0 errors, 1 warnings, 233 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 4/4: scsi-generic: do not do VPD emulation for sense other than 
ILLEGAL_REQUEST...
ERROR: line over 90 characters
#33: FILE: hw/scsi/scsi-generic.c:273:
+        scsi_parse_sense_buf(r->req.sense, r->io_header.sb_len_wr).key == 
ILLEGAL_REQUEST &&

total: 1 errors, 0 warnings, 24 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden