[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 1/7] websock: fix handshake leak
From: |
Marc-André Lureau |
Subject: |
[Qemu-devel] [PULL 1/7] websock: fix handshake leak |
Date: |
Tue, 30 Oct 2018 21:36:21 +0400 |
Missed in f69a8bde293.
Thanks Valgrind:
==955== 217 bytes in 1 blocks are definitely lost in loss record 275 of 321
==955== at 0x483A965: realloc (vg_replace_malloc.c:785)
==955== by 0x50B6839: __vasprintf_chk (in /usr/lib64/libc-2.28.so)
==955== by 0x49AA05C: g_vasprintf (in /usr/lib64/libglib-2.0.so.0.5800.1)
==955== by 0x4983440: g_strdup_vprintf (in
/usr/lib64/libglib-2.0.so.0.5800.1)
==955== by 0x126048: qio_channel_websock_handshake_send_res
(channel-websock.c:162)
==955== by 0x1266E6: qio_channel_websock_handshake_send_res_ok
(channel-websock.c:362)
==955== by 0x126D3E: qio_channel_websock_handshake_process
(channel-websock.c:468)
==955== by 0x126EF2: qio_channel_websock_handshake_read
(channel-websock.c:511)
==955== by 0x12715B: qio_channel_websock_handshake_io (channel-websock.c:571)
==955== by 0x125027: qio_channel_fd_source_dispatch (channel-watch.c:84)
==955== by 0x496326C: g_main_context_dispatch (in
/usr/lib64/libglib-2.0.so.0.5800.1)
==955== by 0x169EC3: glib_pollfds_poll (main-loop.c:215)
Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Daniel P. Berrangé <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
---
io/channel-websock.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/io/channel-websock.c b/io/channel-websock.c
index e6608b969d..dc43dc6bb9 100644
--- a/io/channel-websock.c
+++ b/io/channel-websock.c
@@ -163,6 +163,7 @@ qio_channel_websock_handshake_send_res(QIOChannelWebsock
*ioc,
responselen = strlen(response);
buffer_reserve(&ioc->encoutput, responselen);
buffer_append(&ioc->encoutput, response, responselen);
+ g_free(response);
va_end(vargs);
}
--
2.19.1.708.g4ede3d42df
- [Qemu-devel] [PULL 0/7] Chardev patches, Marc-André Lureau, 2018/10/30
- [Qemu-devel] [PULL 1/7] websock: fix handshake leak,
Marc-André Lureau <=
- [Qemu-devel] [PULL 3/7] char-socket: make 'fd' incompatible with 'reconnect', Marc-André Lureau, 2018/10/30
- [Qemu-devel] [PULL 2/7] char-socket: correctly set has_reconnect when parsing QemuOpts, Marc-André Lureau, 2018/10/30
- [Qemu-devel] [PULL 4/7] chardev/char-socket: Function headers refactoring, Marc-André Lureau, 2018/10/30
- [Qemu-devel] [PULL 6/7] tests/test-char: Check websocket chardev functionality, Marc-André Lureau, 2018/10/30
- [Qemu-devel] [PULL 7/7] editorconfig: set emacs mode, Marc-André Lureau, 2018/10/30
- [Qemu-devel] [PULL 5/7] chardev: Add websocket support, Marc-André Lureau, 2018/10/30
- Re: [Qemu-devel] [PULL 0/7] Chardev patches, Peter Maydell, 2018/10/31