Re: [Qemu-devel] [PATCH v2 4/5] target/mips: Misc R5900-related cosmetic changes

[Philippe Mathieu-Daudé]

On 30/10/18 13:47, Philippe Mathieu-Daudé wrote:
> On 30/10/18 12:36, Aleksandar Markovic wrote:
> > From: Aleksandar Markovic <address@hidden>
> >
> > Misc changes in comments and strings for R5900.
> >
> > Signed-off-by: Aleksandar Markovic <address@hidden>
> > ---
> >   target/mips/translate.c          | 14 +++++++-------
> >   target/mips/translate_init.inc.c | 12 ------------
> >   2 files changed, 7 insertions(+), 19 deletions(-)
> >
> > diff --git a/target/mips/translate.c b/target/mips/translate.c
> > index 155331f..259ad2b 100644
> > --- a/target/mips/translate.c
> > +++ b/target/mips/translate.c
> > @@ -2096,8 +2096,8 @@ enum {
> >    * MTSAH   rs, immediate     Move Halfword Count to Shift Amount 
> > Register
> >    * PROT3W  rd, rt            Parallel Rotate 3 Words
> >    *
> > - *     The TX79-specific Multimedia Instruction encodings
> > - *     ==================================================
> > + *     Multimedia Instructions (MMI) encodings
>
> Oh now I see this. I this single change should be squashed into patch #2 

I forgot the verb ;) I <think> this change ...

> of this series.
>
> Also, maybe use "MultiMedia ..."