[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 19/19] hw: i386: Implement the ACPI builder i
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v3 19/19] hw: i386: Implement the ACPI builder interface for PC |
Date: |
Mon, 29 Oct 2018 18:28:39 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 29/10/2018 18:01, Samuel Ortiz wrote:
> @@ -1556,6 +1557,7 @@ void acpi_build(AcpiBuildTables *tables,
> GArray *tables_blob = tables->table_data;
> AcpiSlicOem slic_oem = { .id = NULL, .table_id = NULL };
> Object *vmgenid_dev;
> + AcpiBuilder *ab = ACPI_BUILDER(machine);
>
> acpi_get_pm_info(&pm);
> acpi_get_misc_info(&misc);
> @@ -1605,7 +1607,8 @@ void acpi_build(AcpiBuildTables *tables,
> aml_len += tables_blob->len - fadt;
>
> acpi_add_table(table_offsets, tables_blob);
> - build_madt(tables_blob, tables->linker, machine, conf);
> + acpi_builder_madt(ab, tables_blob, tables->linker,
> + machine, conf);
>
> vmgenid_dev = find_vmgenid_dev();
> if (vmgenid_dev) {
Just a quick question before I go and actually apply the patches to look
at the resulting code: is there any reason why you didn't add the
MachineState and/or AcpiBuilder to AcpiBuildState, similar to how it was
in v1?
Thanks,
Paolo
- Re: [Qemu-devel] [PATCH v3 15/19] hw: acpi: Export the PCI hotplug API, (continued)
- [Qemu-devel] [PATCH v3 10/19] hw: acpi: Export the MCFG getter, Samuel Ortiz, 2018/10/29
- [Qemu-devel] [PATCH v3 18/19] hw: i386: Export the MADT build method, Samuel Ortiz, 2018/10/29
- [Qemu-devel] [PATCH v3 13/19] hw: acpi: Export the SRAT AML build API, Samuel Ortiz, 2018/10/29
- [Qemu-devel] [PATCH v3 17/19] hw: acpi: Define ACPI tables builder interface, Samuel Ortiz, 2018/10/29
- [Qemu-devel] [PATCH v3 19/19] hw: i386: Implement the ACPI builder interface for PC, Samuel Ortiz, 2018/10/29
- Re: [Qemu-devel] [PATCH v3 19/19] hw: i386: Implement the ACPI builder interface for PC,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH v3 19/19] hw: i386: Implement the ACPI builder interface for PC, Philippe Mathieu-Daudé, 2018/10/29