[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 04/10] cputlb: Split large page tracking per mmu
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH 04/10] cputlb: Split large page tracking per mmu_idx |
Date: |
Sun, 28 Oct 2018 02:30:44 +0000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 |
On 10/27/18 1:16 AM, Emilio G. Cota wrote:
> On Tue, Oct 23, 2018 at 08:02:47 +0100, Richard Henderson wrote:
>> +static void tlb_flush_page_locked(CPUArchState *env, int midx,
>> + target_ulong addr)
>> +{
>> + target_ulong lp_addr = env->tlb_d[midx].large_page_addr;
>> + target_ulong lp_mask = env->tlb_d[midx].large_page_mask;
>> +
>> + /* Check if we need to flush due to large pages. */
>> + if ((addr & lp_mask) == lp_addr) {
>> + tlb_debug("forcing full flush midx %d ("
>> + TARGET_FMT_lx "/" TARGET_FMT_lx ")\n",
>> + midx, lp_addr, lp_mask);
>> + tlb_flush_one_mmuidx_locked(env, midx);
>> + } else {
>> + int pidx = (addr >> TARGET_PAGE_BITS) & (CPU_TLB_SIZE - 1);
>> + tlb_flush_entry_locked(&env->tlb_table[midx][pidx], addr);
>> + tlb_flush_vtlb_page_locked(env, midx, addr);
>
> Just noticed that we should use tlb_entry here, e.g.:
>
> } else {
> - int pidx = (addr >> TARGET_PAGE_BITS) & (CPU_TLB_SIZE - 1);
> - tlb_flush_entry_locked(&env->tlb_table[midx][pidx], addr);
> + CPUTLBEntry *entry = tlb_entry(env, midx, addr);
> +
> + tlb_flush_entry_locked(entry, addr);
> tlb_flush_vtlb_page_locked(env, midx, addr);
> }
Fixed, thanks.
r~
- [Qemu-devel] [PATCH 10/10] cputlb: Remove tlb_c.pending_flushes, (continued)
- [Qemu-devel] [PATCH 10/10] cputlb: Remove tlb_c.pending_flushes, Richard Henderson, 2018/10/23
- [Qemu-devel] [PATCH 01/10] cputlb: Move tlb_lock to CPUTLBCommon, Richard Henderson, 2018/10/23
- [Qemu-devel] [PATCH 06/10] cputlb: Merge tlb_flush_nocheck into tlb_flush_by_mmuidx_async_work, Richard Henderson, 2018/10/23
- [Qemu-devel] [PATCH 02/10] cputlb: Remove tcg_enabled hack from tlb_flush_nocheck, Richard Henderson, 2018/10/23
- [Qemu-devel] [PATCH 03/10] cputlb: Move cpu->pending_tlb_flush to env->tlb_c.pending_flush, Richard Henderson, 2018/10/23
- [Qemu-devel] [PATCH 08/10] cputlb: Count "partial" and "elided" tlb flushes, Richard Henderson, 2018/10/23
- [Qemu-devel] [PATCH 09/10] cputlb: Filter flushes on already clean tlbs, Richard Henderson, 2018/10/23
- [Qemu-devel] [PATCH 04/10] cputlb: Split large page tracking per mmu_idx, Richard Henderson, 2018/10/23
- [Qemu-devel] [PATCH, build fix] osdep: Work around MinGW assert, Richard Henderson, 2018/10/23
- [Qemu-devel] [PATCH 07/10] cputlb: Merge tlb_flush_page into tlb_flush_page_by_mmuidx, Richard Henderson, 2018/10/23
- [Qemu-devel] [PATCH 05/10] cputlb: Move env->vtlb_index to env->tlb_d.vindex, Richard Henderson, 2018/10/23
- Re: [Qemu-devel] [PATCH 00/10] cputlb: track dirty tlbs and general cleanup, Emilio G. Cota, 2018/10/23