[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL v2 00/28] pci, pc, virtio: fixes, features
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PULL v2 00/28] pci, pc, virtio: fixes, features |
Date: |
Fri, 26 Oct 2018 20:21:06 +0100 |
On 26 October 2018 at 14:26, Singh, Brijesh <address@hidden> wrote:
>
>
> On 10/25/2018 07:59 PM, Michael S. Tsirkin wrote:
>> On Thu, Oct 25, 2018 at 08:16:44PM +0100, Peter Maydell wrote:
>>> These should presumably all be "ULL". (The "UL" suffix is
>>> usually a bug, as it's either unnecessary or should be ULL.)
>>
>> Yea. Fixed. Brijesh could you start cleaning up that header generally?
>> It has all kind of weird code like using bitfields for hardware
>> accesses. That isn't portable - switch to full dword fields with shift
>> and | to operate them and proper cpu_to_le APIs or similar please.
>>
>
>
> Noted, I will look into cleaning up this and send patches for reviews.
Thanks. You might like to look at the extract32()/extract64()/
deposit32()/deposit64() functions in bitops.h, which are often (but not
always) cleaner than hand-rolled shifts-and-logical-ops for assembling
and disassembling fields.
thanks
-- PMM
- [Qemu-devel] [PULL v2 23/28] hw/pci: Add missing include, (continued)
- [Qemu-devel] [PULL v2 23/28] hw/pci: Add missing include, Michael S. Tsirkin, 2018/10/24
- [Qemu-devel] [PULL v2 20/28] tests/bios-tables-test: add 64-bit PCI MMIO aperture round-up test on Q35, Michael S. Tsirkin, 2018/10/24
- [Qemu-devel] [PULL v2 25/28] i440fx: use ARRAY_SIZE for pam_regions, Michael S. Tsirkin, 2018/10/24
- [Qemu-devel] [PULL v2 24/28] pci_bridge: fix typo in comment, Michael S. Tsirkin, 2018/10/24
- [Qemu-devel] [PULL v2 26/28] piix: use TYPE_FOO constants than string constats, Michael S. Tsirkin, 2018/10/24
- [Qemu-devel] [PULL v2 27/28] piix_pci: fix i440fx data sheet link, Michael S. Tsirkin, 2018/10/24
- [Qemu-devel] [PULL v2 28/28] vhost-scsi: prevent using uninitialized vqs, Michael S. Tsirkin, 2018/10/24
- Re: [Qemu-devel] [PULL v2 00/28] pci, pc, virtio: fixes, features, Peter Maydell, 2018/10/25
- Re: [Qemu-devel] [PULL v2 00/28] pci, pc, virtio: fixes, features, Michael S. Tsirkin, 2018/10/25
- Re: [Qemu-devel] [PULL v2 00/28] pci, pc, virtio: fixes, features, Singh, Brijesh, 2018/10/26
- Re: [Qemu-devel] [PULL v2 00/28] pci, pc, virtio: fixes, features,
Peter Maydell <=
- Re: [Qemu-devel] [PULL v2 00/28] pci, pc, virtio: fixes, features, Michael S. Tsirkin, 2018/10/25
- Re: [Qemu-devel] [PULL v2 00/28] pci, pc, virtio: fixes, features, Michael S. Tsirkin, 2018/10/25
- Re: [Qemu-devel] [PULL v2 00/28] pci, pc, virtio: fixes, features, Peter Maydell, 2018/10/27
- Re: [Qemu-devel] [PULL v2 00/28] pci, pc, virtio: fixes, features, Peter Maydell, 2018/10/30