[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 0/4] hw/misc: Add a MMIO interface to the pv
Re: [Qemu-devel] [PATCH v3 0/4] hw/misc: Add a MMIO interface to the pvpanicdevice
Thu, 25 Oct 2018 13:47:12 +0800 (CST)
>On 18/10/2018 15:04, Philippe Mathieu-Daudé wrote:
>> Hi, this series takes Peng Hao's previous work but rather than adding yet
>> another device, simply add the MMIO interface to the current device (which
>> only implements the I/O port access).
>> The first patches are simple cleanups:
>> - patch 1 move the pvpanic device with the 'ocmmon objects' so we compile
>> it once for the x86/arm/aarch64 archs,
>> - patch 2 simply renames ISA fields/definitions to generic ones.
>> Then instead of add/use the MMIO pvpanic device in the virt machine in an
>> unique patch, I split it in two distinct patches:
>> - patch 3 uses Peng Hao's work, but add the MMIO interface to the existing
>> device (no logical change).
>> - patch 4 is Peng Hao's work in the virt machine (no logical change).
>> v2 from Peng Hao is:
>> Philippe Mathieu-Daudé (4):
>> hw/misc/pvpanic: Build the pvpanic device in $(common-obj)
>> hw/misc/pvpanic: Cosmetic renaming
>Oops I failed when rebasing, these two are supposed to be from
now it can works.
In refactoring code, there is still a need to add a type to distinguish
different bus device.
I add a type TYPE_PVPANIC_MMIO for sysbus pvpanic device and
orignal TYPE_PVPANIC for isa pvpanic deivce.
bindling-DT "qemu,pvpanic-mmio" in kernel is in review.
I will resubmit patches.
>with below my S-o-b:
>[PMD: Use TYPE_PVPANIC definition, split in 2 patches,
>improved patch subject]
>> hw/misc/pvpanic: Add the MMIO interface
>> hw/arm/virt: Use the pvpanic device
>> default-configs/arm-softmmu.mak | 2 +-
>> hw/arm/virt.c | 21 ++++++++++
>> hw/misc/Makefile.objs | 2 +-
>> hw/misc/pvpanic.c | 68 +++++++++++++++++++++++++++++----
>> include/hw/arm/virt.h | 1 +
>> 5 files changed, 84 insertions(+), 10 deletions(-)