Re: [Qemu-devel] [PATCH 2/7] decodetree: Remove "insn" argument from trans_* expanders

[Bastian Koppelmann]

On 10/23/18 3:08 PM, Richard Henderson wrote:
> On 10/23/18 2:04 PM, Bastian Koppelmann wrote:
> > On 10/23/18 2:04 PM, Richard Henderson wrote:
> > > ??? Needs simultaneous corresponding changes to all
> > > translators using decodetree.
> > > ---
> > >    scripts/decodetree.py | 5 ++---
> > >    1 file changed, 2 insertions(+), 3 deletions(-)
> > Was the only intend of the insn argument to be used for manual decoding in a
> > trans_ function?
> I didn't quite know what it might be used for, and thought I was planning
> ahead.  Now I see that it's probably counter-productive.


Richard, can you pick up the first two patches together with the insn 
arg removal for openrisc and ARM, such that we don't break bisecting? I 
then squash the rest of the patches into my patch-set.

Cheers,

Bastian