Re: [Qemu-devel] [PATCH, build fix] osdep: Work around MinGW assert

[Peter Maydell]

On 22 October 2018 at 19:16, Richard Henderson
<address@hidden> wrote:
> In several places we use assert(FEATURE), and assume that if FEATURE
> is disabled, all following code is removed as unreachable.  Which allows
> us to compile-out functions that are only present with FEATURE, and
> have a link-time failure if the functions remain used.
>
> MinGW does not mark its internal function _assert() as noreturn, so the
> compiler cannot see when code is unreachable, which leads to link errors
> for this host that are not present elsewhere.
>
> The current build-time failure concerns 62823083b8a2, but I remember
> having seen this same error before.  Fix it once and for all for MinGW.
>

Applied to master (with the typo fixed), thanks.

-- PMM