[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 6/9] iotests: Explicitly inherit FDs in Pytho
From: |
Cleber Rosa |
Subject: |
Re: [Qemu-devel] [PATCH v2 6/9] iotests: Explicitly inherit FDs in Python |
Date: |
Fri, 19 Oct 2018 20:54:17 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 10/19/18 3:15 PM, Max Reitz wrote:
> Python 3.4 introduced the inheritable attribute for FDs. At the same
> time, it changed the default so that all FDs are not inheritable by
> default, that only inheritable FDs are inherited to subprocesses, and
> only if close_fds is explicitly set to False.
>
> Adhere to this by setting close_fds to False when working with
> subprocesses that may want to inherit FDs, and by trying to
> set_inheritable() on FDs that we do want to bequeath to them.
>
> Signed-off-by: Max Reitz <address@hidden>
Reviewed-by: Cleber Rosa <address@hidden>
- [Qemu-devel] [PATCH v2 0/9] iotests: Make them work for both Python 2 and 3, Max Reitz, 2018/10/19
- [Qemu-devel] [PATCH v2 2/9] iotests: Flush in iotests.py's QemuIoInteractive, Max Reitz, 2018/10/19
- [Qemu-devel] [PATCH v2 7/9] iotests: 'new' module replacement in 169, Max Reitz, 2018/10/19
- [Qemu-devel] [PATCH v2 1/9] iotests: Make nbd-fault-injector flush, Max Reitz, 2018/10/19
- [Qemu-devel] [PATCH v2 3/9] iotests: Use Python byte strings where appropriate, Max Reitz, 2018/10/19
- [Qemu-devel] [PATCH v2 6/9] iotests: Explicitly inherit FDs in Python, Max Reitz, 2018/10/19
- [Qemu-devel] [PATCH v2 5/9] iotests: Different iterator behavior in Python 3, Max Reitz, 2018/10/19
- [Qemu-devel] [PATCH v2 8/9] iotests: Modify imports for Python 3, Max Reitz, 2018/10/19
- [Qemu-devel] [PATCH v2 4/9] iotests: Use // for Python integer division, Max Reitz, 2018/10/19
- [Qemu-devel] [PATCH v2 9/9] iotests: Unify log outputs between Python 2 and 3, Max Reitz, 2018/10/19