qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 16/28] target/riscv: Convert quadrant 1 of RVXC


From: Bastian Koppelmann
Subject: Re: [Qemu-devel] [PATCH 16/28] target/riscv: Convert quadrant 1 of RVXC insns to decodetree
Date: Fri, 19 Oct 2018 15:20:42 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1


On 10/13/18 8:53 PM, Richard Henderson wrote:
Choose return false or raise exception. Except...
I wonder if we might write this as

     int shamt = a->shamt;
     if (shamt == 0) {
         shamt = 64;
     }


Good catch. I'll add a comment, that a shamt of 0 is intended for RV128.


Cheers,

Bastian




reply via email to

[Prev in Thread] Current Thread [Next in Thread]