[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] es1370: more fixes for ADC_FRAMEADR and ADC_FRA
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH] es1370: more fixes for ADC_FRAMEADR and ADC_FRAMECNT |
|
Date: |
Fri, 19 Oct 2018 13:43:07 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 19/10/2018 10:46, Thomas Huth wrote:
>>
> It's in a pull request already, so this is likely too late: But for the
> next time, could you maybe rather use a "/* fall through */" comment
> instead of a goto? That looks less ugly.
Wait, it's not ugly, it's wrong. The label is placed incorrectly.
Paolo