[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 27/38] vnc: Clean up error reporting in vnc_i
|
From: |
Gerd Hoffmann |
|
Subject: |
Re: [Qemu-devel] [PATCH v4 27/38] vnc: Clean up error reporting in vnc_init_func() |
|
Date: |
Fri, 19 Oct 2018 08:52:29 +0200 |
|
User-agent: |
NeoMutt/20180716 |
On Wed, Oct 17, 2018 at 10:26:51AM +0200, Markus Armbruster wrote:
> Calling error_report() in a function that takes an Error ** argument
> is suspicious. vnc_init_func() does that, and then fails without
> setting an error. Its caller main(), via qemu_opts_foreach(), is fine
> with it, but clean it up anyway.
>
> While there, drop a "Failed to start VNC server: " error message
> prefix that doesn't really add value.
>
> Cc: Gerd Hoffmann <address@hidden>
> Signed-off-by: Markus Armbruster <address@hidden>
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Gerd Hoffmann <address@hidden>
- Re: [Qemu-devel] [PATCH v4 03/38] block: Use warn_report() & friends to report warnings, (continued)
[Qemu-devel] [PATCH v4 18/38] vl: Clean up error reporting in parse_add_fd(), Markus Armbruster, 2018/10/17
[Qemu-devel] [PATCH v4 11/38] smbios: Clean up error handling in smbios_add(), Markus Armbruster, 2018/10/17
[Qemu-devel] [PATCH v4 20/38] vl: Clean up error reporting in chardev_init_func(), Markus Armbruster, 2018/10/17
[Qemu-devel] [PATCH v4 15/38] numa: Fix QMP command set-numa-node error handling, Markus Armbruster, 2018/10/17
[Qemu-devel] [PATCH v4 13/38] l2tpv3: Improve -netdev/netdev_add/-net/... error reporting, Markus Armbruster, 2018/10/17
[Qemu-devel] [PATCH v4 22/38] vl: Clean up error reporting in mon_init_func(), Markus Armbruster, 2018/10/17
[Qemu-devel] [PATCH v4 27/38] vnc: Clean up error reporting in vnc_init_func(), Markus Armbruster, 2018/10/17
- Re: [Qemu-devel] [PATCH v4 27/38] vnc: Clean up error reporting in vnc_init_func(),
Gerd Hoffmann <=
[Qemu-devel] [PATCH v4 21/38] vl: Clean up error reporting in machine_set_property(), Markus Armbruster, 2018/10/17
[Qemu-devel] [PATCH v4 06/38] vfio: Clean up error reporting after previous commit, Markus Armbruster, 2018/10/17
[Qemu-devel] [PATCH v4 19/38] qom: Clean up error reporting in user_creatable_add_opts_foreach(), Markus Armbruster, 2018/10/17
[Qemu-devel] [PATCH v4 23/38] vl: Clean up error reporting in parse_fw_cfg(), Markus Armbruster, 2018/10/17
[Qemu-devel] [PATCH v4 24/38] vl: Clean up error reporting in device_init_func(), Markus Armbruster, 2018/10/17
[Qemu-devel] [PATCH v4 28/38] numa: Clean up error reporting in parse_numa(), Markus Armbruster, 2018/10/17
[Qemu-devel] [PATCH v4 30/38] spice: Clean up error reporting in add_channel(), Markus Armbruster, 2018/10/17
[Qemu-devel] [PATCH v4 33/38] blockdev: Convert drive_new() to Error, Markus Armbruster, 2018/10/17
[Qemu-devel] [PATCH v4 29/38] tpm: Clean up error reporting in tpm_init_tpmdev(), Markus Armbruster, 2018/10/17