[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 4/4] Optimize record/replay checkpointing for
From: |
Artem Pisarenko |
Subject: |
Re: [Qemu-devel] [PATCH v3 4/4] Optimize record/replay checkpointing for all clocks it applies to |
Date: |
Fri, 19 Oct 2018 12:30:17 +0600 |
> …
> This is wrong at least for QEMU_CLOCK_HOST.
> …
> Reading the host clock here is not protected by the checkpoint.
> Therefore it may incur the inconsistency when replaying the execution.
That's why I didn't like idea of this patch and asked for any possible side
effects beforehand. So, here is one.
I have no idea how to fix it properly and would like to recall this
particular patch from these series (remember, it doesn't match series
goal). Lets leave this patch/issue for separate resolution, although I'm
not very interested in it.
- [Qemu-devel] [PATCH v3 0/4] Introduce attributes for timers subsystem and remove QEMU_CLOCK_VIRTUAL_EXT clock type, Artem Pisarenko, 2018/10/18
- [Qemu-devel] [PATCH v3 1/4] Revert some patches from recent [PATCH v6] "Fixing record/replay and adding reverse debugging", Artem Pisarenko, 2018/10/18
- [Qemu-devel] [PATCH v3 3/4] Restores record/replay behavior related to special virtual clock processing for timers used in external subsystems., Artem Pisarenko, 2018/10/18
- [Qemu-devel] [PATCH v3 2/4] Introduce attributes to qemu timer subsystem, Artem Pisarenko, 2018/10/18
- [Qemu-devel] [PATCH v3] Optimize record/replay checkpointing for all clocks it applies to, Artem Pisarenko, 2018/10/18