qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] scripts: Remove check-qerror.sh


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH] scripts: Remove check-qerror.sh
Date: Wed, 17 Oct 2018 19:25:32 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)

Alberto Garcia <address@hidden> writes:

> qerror.h contains leftovers from the now-defunct QError API.
>
> There's only a handful of string macros left, and no one is supposed
> to add anything else. The check-qerror.sh script was used to make sure
> that all definitions on the qerror.c and qerror.h files were sorted
> alphabetically. The former was removed three years ago, and the latter
> is now in a different location, so the script doesn't even work (as
> a matter of fact the alphabetical order was broken last time someone
> added a macro -also in 2015- and no one seemed to notice).
>
> There's no point in fixing this script so let's just remove it.
> The rogue macro is also moved to its correct location.
>
> Signed-off-by: Alberto Garcia <address@hidden>

Reviewed-by: Markus Armbruster <address@hidden>

Queued, thanks!



reply via email to

[Prev in Thread] Current Thread [Next in Thread]