qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 2/4] target/mips: Remove definitions that are


From: Aleksandar Markovic
Subject: Re: [Qemu-devel] [PATCH v3 2/4] target/mips: Remove definitions that are only used once
Date: Wed, 17 Oct 2018 12:08:53 +0000

> From: Philippe Mathieu-Daudé <address@hidden> on behalf of Philippe 
> Mathieu-Daudé <address@hidden>
> Subject: [PATCH v3 2/4] target/mips: Remove definitions that are only used 
> once
>
> There is no gain in adding cpu definition which is used only once.
> Use the chip specific flags directly in place.
> This also clears the 'MIPS CPU defines' namespace.
> 
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---

Being used only once is not a sufficient reason for deleting a preprocessor 
constant. The constants in this case are just fine as they are.

Thanks,
Aleksandar


reply via email to

[Prev in Thread] Current Thread [Next in Thread]