[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 14/15] hw/core/generic-loader: Compile only once, not
From: |
Thomas Huth |
Subject: |
[Qemu-devel] [PULL 14/15] hw/core/generic-loader: Compile only once, not for each target |
Date: |
Wed, 17 Oct 2018 12:05:06 +0200 |
The generic-loader is currently compiled target specific due to one
single "#ifdef TARGET_WORDS_BIGENDIAN" in the file. We have already a
function called target_words_bigendian() for this instead, so we can
put the generic-loader into common-obj to save some compilation time.
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Laszlo Ersek <address@hidden>
Reviewed-by: Alistair Francis <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>
---
hw/core/Makefile.objs | 2 +-
hw/core/generic-loader.c | 6 +-----
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/hw/core/Makefile.objs b/hw/core/Makefile.objs
index eb88ca9..b736ce2 100644
--- a/hw/core/Makefile.objs
+++ b/hw/core/Makefile.objs
@@ -20,6 +20,6 @@ common-obj-$(CONFIG_SOFTMMU) += register.o
common-obj-$(CONFIG_SOFTMMU) += or-irq.o
common-obj-$(CONFIG_SOFTMMU) += split-irq.o
common-obj-$(CONFIG_PLATFORM_BUS) += platform-bus.o
+common-obj-$(CONFIG_SOFTMMU) += generic-loader.o
-obj-$(CONFIG_SOFTMMU) += generic-loader.o
obj-$(CONFIG_SOFTMMU) += null-machine.o
diff --git a/hw/core/generic-loader.c b/hw/core/generic-loader.c
index be29ae1..fbae05f 100644
--- a/hw/core/generic-loader.c
+++ b/hw/core/generic-loader.c
@@ -130,11 +130,7 @@ static void generic_loader_realize(DeviceState *dev, Error
**errp)
s->cpu = first_cpu;
}
-#ifdef TARGET_WORDS_BIGENDIAN
- big_endian = 1;
-#else
- big_endian = 0;
-#endif
+ big_endian = target_words_bigendian();
if (s->file) {
AddressSpace *as = s->cpu ? s->cpu->as : NULL;
--
1.8.3.1
- [Qemu-devel] [PULL 00/15] qtest and misc patches, Thomas Huth, 2018/10/17
- [Qemu-devel] [PULL 02/15] target/cris/translate: Get rid of qemu_log_separate(), Thomas Huth, 2018/10/17
- [Qemu-devel] [PULL 01/15] qemu-common.h: update copyright date to 2018, Thomas Huth, 2018/10/17
- [Qemu-devel] [PULL 03/15] tests: Prevent more accidental test disabling, Thomas Huth, 2018/10/17
- [Qemu-devel] [PULL 04/15] tests: remove gcov-files- variables, Thomas Huth, 2018/10/17
- [Qemu-devel] [PULL 05/15] gdbstub: Remove unused include, Thomas Huth, 2018/10/17
- [Qemu-devel] [PULL 10/15] mailmap: Fix Reimar Döffinger name, Thomas Huth, 2018/10/17
- [Qemu-devel] [PULL 08/15] git-submodule.sh: Modern shell scripting (use $() instead of ``), Thomas Huth, 2018/10/17
- [Qemu-devel] [PULL 15/15] configure: remove glib_subprocess check, Thomas Huth, 2018/10/17
- [Qemu-devel] [PULL 09/15] show-fixed-bugs.sh: Modern shell scripting (use $() instead of ``), Thomas Huth, 2018/10/17
- [Qemu-devel] [PULL 14/15] hw/core/generic-loader: Compile only once, not for each target,
Thomas Huth <=
- [Qemu-devel] [PULL 06/15] MAINTAINERS: update block/sheepdog maintainers, Thomas Huth, 2018/10/17
- [Qemu-devel] [PULL 07/15] archive-source.sh: Modern shell scripting (use $() instead of ``), Thomas Huth, 2018/10/17
- [Qemu-devel] [PULL 12/15] hw/core/generic-loader: Set a category for the generic-loader device, Thomas Huth, 2018/10/17
- [Qemu-devel] [PULL 13/15] cpu: Provide a proper prototype for target_words_bigendian() in a header, Thomas Huth, 2018/10/17
- [Qemu-devel] [PULL 11/15] qemu/compiler: Wrap __attribute__((flatten)) in a macro, Thomas Huth, 2018/10/17
- Re: [Qemu-devel] [PULL 00/15] qtest and misc patches, Peter Maydell, 2018/10/18