[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 02/15] target/cris/translate: Get rid of qemu_log_sep
From: |
Thomas Huth |
Subject: |
[Qemu-devel] [PULL 02/15] target/cris/translate: Get rid of qemu_log_separate() |
Date: |
Wed, 17 Oct 2018 12:04:54 +0200 |
The gen_BUG() function calls already cpu_abort(), which prints the
information to stderr and the log already. So instead of additionally
printing the dc->pc via fprintf() and qemu_log here, too, we can
simply pass this information to cpu_abort() instead.
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>
---
target/cris/translate.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/target/cris/translate.c b/target/cris/translate.c
index 4ae1c04..11b2c11 100644
--- a/target/cris/translate.c
+++ b/target/cris/translate.c
@@ -137,11 +137,7 @@ typedef struct DisasContext {
static void gen_BUG(DisasContext *dc, const char *file, int line)
{
- fprintf(stderr, "BUG: pc=%x %s %d\n", dc->pc, file, line);
- if (qemu_log_separate()) {
- qemu_log("BUG: pc=%x %s %d\n", dc->pc, file, line);
- }
- cpu_abort(CPU(dc->cpu), "%s:%d\n", file, line);
+ cpu_abort(CPU(dc->cpu), "%s:%d pc=%x\n", file, line, dc->pc);
}
static const char *regnames_v32[] =
--
1.8.3.1
- [Qemu-devel] [PULL 00/15] qtest and misc patches, Thomas Huth, 2018/10/17
- [Qemu-devel] [PULL 02/15] target/cris/translate: Get rid of qemu_log_separate(),
Thomas Huth <=
- [Qemu-devel] [PULL 01/15] qemu-common.h: update copyright date to 2018, Thomas Huth, 2018/10/17
- [Qemu-devel] [PULL 03/15] tests: Prevent more accidental test disabling, Thomas Huth, 2018/10/17
- [Qemu-devel] [PULL 04/15] tests: remove gcov-files- variables, Thomas Huth, 2018/10/17
- [Qemu-devel] [PULL 05/15] gdbstub: Remove unused include, Thomas Huth, 2018/10/17
- [Qemu-devel] [PULL 10/15] mailmap: Fix Reimar Döffinger name, Thomas Huth, 2018/10/17
- [Qemu-devel] [PULL 08/15] git-submodule.sh: Modern shell scripting (use $() instead of ``), Thomas Huth, 2018/10/17
- [Qemu-devel] [PULL 15/15] configure: remove glib_subprocess check, Thomas Huth, 2018/10/17
- [Qemu-devel] [PULL 09/15] show-fixed-bugs.sh: Modern shell scripting (use $() instead of ``), Thomas Huth, 2018/10/17
- [Qemu-devel] [PULL 14/15] hw/core/generic-loader: Compile only once, not for each target, Thomas Huth, 2018/10/17
- [Qemu-devel] [PULL 06/15] MAINTAINERS: update block/sheepdog maintainers, Thomas Huth, 2018/10/17