[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH v2 2/4] Introduce attributes to qem
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [Qemu-block] [PATCH v2 2/4] Introduce attributes to qemu timer subsystem |
|
Date: |
Wed, 17 Oct 2018 11:15:36 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 17/10/2018 11:12, Stefan Hajnoczi wrote:
>> Attributes are simple flags, associated with individual timers for their
>> whole lifetime.
>> They intended to be used to mark individual timers for special handling by
>> various qemu features operating at qemu core level.
> I'm worried that this sentence suggests various parts of QEMU will stash
> state in ts->attributes. That's messy and they shouldn't do this. Make
> the field private to qemu-timer.c.
Yes, the contents of the fields are private. Are you suggesting a
different wording for the commit message or the "QEMU Timer attributes"
doc comment, or something more than that? Possibly removing
timer_get_attributes altogether?
Paolo
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 0/4] Introduce attributes for timers subsystem and remove QEMU_CLOCK_VIRTUAL_EXT clock type, Artem Pisarenko, 2018/10/17
- [Qemu-devel] [PATCH v2 1/4] Revert some patches from recent [PATCH v6] "Fixing record/replay and adding reverse debugging", Artem Pisarenko, 2018/10/17
- [Qemu-devel] [PATCH v2 4/4] Optimize record/replay checkpointing for all clocks it applies to, Artem Pisarenko, 2018/10/17
- [Qemu-devel] [PATCH v2 2/4] Introduce attributes to qemu timer subsystem, Artem Pisarenko, 2018/10/17
- Re: [Qemu-devel] [Qemu-block] [PATCH v2 2/4] Introduce attributes to qemu timer subsystem, Stefan Hajnoczi, 2018/10/17
- Re: [Qemu-devel] [Qemu-block] [PATCH v2 2/4] Introduce attributes to qemu timer subsystem,
Paolo Bonzini <=
- Re: [Qemu-devel] [Qemu-block] [PATCH v2 2/4] Introduce attributes to qemu timer subsystem, Artem Pisarenko, 2018/10/17
- Re: [Qemu-devel] [Qemu-block] [PATCH v2 2/4] Introduce attributes to qemu timer subsystem, Paolo Bonzini, 2018/10/17
- Re: [Qemu-devel] [Qemu-block] [PATCH v2 2/4] Introduce attributes to qemu timer subsystem, Artem Pisarenko, 2018/10/17
- Re: [Qemu-devel] [Qemu-block] [PATCH v2 2/4] Introduce attributes to qemu timer subsystem, Paolo Bonzini, 2018/10/17
- Re: [Qemu-devel] [Qemu-block] [PATCH v2 2/4] Introduce attributes to qemu timer subsystem, Artem Pisarenko, 2018/10/17
- Re: [Qemu-devel] [Qemu-block] [PATCH v2 2/4] Introduce attributes to qemu timer subsystem, Stefan Hajnoczi, 2018/10/18
[Qemu-devel] [PATCH v2 3/4] Restores record/replay behavior related to special virtual clock processing for timers used in external subsystems., Artem Pisarenko, 2018/10/17