Re: [Qemu-devel] [PATCH 1/3] archive-source.sh: Modern shellscripting (use $() instead of ``)

[maozy]

Hi, Eric

On 10/15/18 11:44 PM, Eric Blake wrote:
> On 10/15/18 1:51 AM, Mao Zhongyi wrote:
> > Various shell files contain a mix between obsolete `` and
> > modern $(); use of `` is only required when using /bin/sh
> > on Solaris. It would be nice to convert to using $()
> > everywhere, or at least in all bash scripts, as well as in
> > all scripts that are known to not be run on Solaris.
>
> Did you have a particular program you used to find these, or just grep?

Just grep in scripts dir, I also entered the file to make sure I didn't 
missing anything. In addition, I will send a separated patch to replace 
all obsolete `` in the source tree.

> Also, when sending a series, don't forget a 0/3 cover letter.

OK, I see. :)
 Thanks,
Mao

> > Signed-off-by: Mao Zhongyi <address@hidden>
> > ---
> >   scripts/archive-source.sh | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)