[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 19/21] plugins: add an example hotblocks plu
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [RFC PATCH 19/21] plugins: add an example hotblocks plugin |
Date: |
Mon, 15 Oct 2018 10:33:31 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 |
On 10/5/18 8:49 AM, Alex Bennée wrote:
> +char *plugin_status(void)
> +{
> + GString *report = g_string_new("We have ");
> + char *r;
> + g_mutex_lock(&lock);
> + g_string_append_printf(report, "%ud entries in the hash table\n",
> + g_hash_table_size(hotblocks));
> + g_mutex_unlock(&lock);
> + r = report->str;
> + g_string_free(report, FALSE);
> + return r;
> +}
You're not reporting the entries themselves?
Also, are you sure you don't want to just return the GString?
r~
- Re: [Qemu-devel] [RFC PATCH 03/21] linux-user: add -dfilter progtext shortcut, (continued)
- [Qemu-devel] [RFC PATCH 06/21] trace: show trace point counts in the monitor, Alex Bennée, 2018/10/05
- [Qemu-devel] [RFC PATCH 15/21] trace: add linux-user plugin support, Alex Bennée, 2018/10/05
- [Qemu-devel] [RFC PATCH 19/21] plugins: add an example hotblocks plugin, Alex Bennée, 2018/10/05
- [Qemu-devel] [RFC PATCH 21/21] plugin: add tlbflush stats plugin, Alex Bennée, 2018/10/05
- [Qemu-devel] [RFC PATCH 20/21] plugins: add hotness summary to hotblocks, Alex Bennée, 2018/10/05
- [Qemu-devel] [RFC PATCH 17/21] hmp: expose status of plugins to the monitor, Alex Bennée, 2018/10/05
- Re: [Qemu-devel] [RFC PATCH 00/21] Trace updates and plugin RFC, Emilio G. Cota, 2018/10/06