[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 20/35] vl: Clean up error reporting in chardev_in
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH v2 20/35] vl: Clean up error reporting in chardev_init_func() |
Date: |
Mon, 15 Oct 2018 13:52:54 +0200 |
Calling error_report() in a function that takes an Error ** argument
is suspicious. chardev_init_func() does that, and then fails without
setting an error. Its caller main(), via qemu_opts_foreach(), is fine
with it, but clean it up anyway.
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
---
vl.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/vl.c b/vl.c
index bb18f2d995..aa03192019 100644
--- a/vl.c
+++ b/vl.c
@@ -2239,7 +2239,7 @@ static int chardev_init_func(void *opaque, QemuOpts
*opts, Error **errp)
if (!qemu_chr_new_from_opts(opts, &local_err)) {
if (local_err) {
- error_report_err(local_err);
+ error_propagate(errp, local_err);
return -1;
}
exit(0);
@@ -4232,10 +4232,8 @@ int main(int argc, char **argv, char **envp)
user_creatable_add_opts_foreach,
object_create_initial, &error_fatal);
- if (qemu_opts_foreach(qemu_find_opts("chardev"),
- chardev_init_func, NULL, NULL)) {
- exit(1);
- }
+ qemu_opts_foreach(qemu_find_opts("chardev"),
+ chardev_init_func, NULL, &error_fatal);
#ifdef CONFIG_VIRTFS
if (qemu_opts_foreach(qemu_find_opts("fsdev"),
--
2.17.1
- [Qemu-devel] [PATCH v2 00/35] Replace some unwise uses of error_report() & friends, Markus Armbruster, 2018/10/15
- [Qemu-devel] [PATCH v2 08/35] 9pfs: Fix CLI parsing crash on error, Markus Armbruster, 2018/10/15
- [Qemu-devel] [PATCH v2 12/35] migration: Fix !replay_can_snapshot() error handling, Markus Armbruster, 2018/10/15
- [Qemu-devel] [PATCH v2 03/35] block: Use warn_report() & friends to report warnings, Markus Armbruster, 2018/10/15
- [Qemu-devel] [PATCH v2 01/35] error: Fix use of error_prepend() with &error_fatal, &error_abort, Markus Armbruster, 2018/10/15
- [Qemu-devel] [PATCH v2 02/35] Use error_fatal to simplify obvious fatal errors (again), Markus Armbruster, 2018/10/15
- [Qemu-devel] [PATCH v2 22/35] vl: Clean up error reporting in mon_init_func(), Markus Armbruster, 2018/10/15
- [Qemu-devel] [PATCH v2 15/35] numa: Fix QMP command set-numa-node error handling, Markus Armbruster, 2018/10/15
- [Qemu-devel] [PATCH v2 19/35] qom: Clean up error reporting in user_creatable_add_opts_foreach(), Markus Armbruster, 2018/10/15
- [Qemu-devel] [PATCH v2 20/35] vl: Clean up error reporting in chardev_init_func(),
Markus Armbruster <=
- [Qemu-devel] [PATCH v2 18/35] vl: Clean up error reporting in parse_add_fd(), Markus Armbruster, 2018/10/15
- [Qemu-devel] [PATCH v2 34/35] vl: Fix exit status for -drive format=help, Markus Armbruster, 2018/10/15
- [Qemu-devel] [PATCH v2 11/35] smbios: Clean up error handling in smbios_add(), Markus Armbruster, 2018/10/15
- [Qemu-devel] [PATCH v2 21/35] vl: Clean up error reporting in machine_set_property(), Markus Armbruster, 2018/10/15
- [Qemu-devel] [PATCH v2 10/35] ioapic: Fix error handling in realize(), Markus Armbruster, 2018/10/15
- [Qemu-devel] [PATCH v2 35/35] vl: Simplify call of parse_name(), Markus Armbruster, 2018/10/15
- [Qemu-devel] [PATCH v2 32/35] vl: Assert drive_new() does not fail in default_drive(), Markus Armbruster, 2018/10/15
- [Qemu-devel] [PATCH v2 25/35] ui/keymaps: Fix handling of erroneous include files, Markus Armbruster, 2018/10/15
- [Qemu-devel] [PATCH v2 14/35] net/socket: Fix invalid socket type error handling, Markus Armbruster, 2018/10/15
- [Qemu-devel] [PATCH v2 33/35] blockdev: Convert drive_new() to Error, Markus Armbruster, 2018/10/15