[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v7 15/19] gdbstub: add reverse continue support in r
From: |
Pavel Dovgalyuk |
Subject: |
[Qemu-devel] [PATCH v7 15/19] gdbstub: add reverse continue support in replay mode |
Date: |
Wed, 10 Oct 2018 16:34:59 +0300 |
User-agent: |
StGit/0.17.1-dirty |
This patch adds support of the reverse continue operation for gdbstub.
Reverse continue finds the last breakpoint that would happen in normal
execution from the beginning to the current moment.
Implementation of the reverse continue replays the execution twice:
to find the breakpoints that were hit and to seek to the last breakpoint.
Reverse continue loads the previous snapshot and tries to find the breakpoint
since that moment. If there are no such breakpoints, it proceeds to
the earlier snapshot, and so on. When no breakpoints or watchpoints were
hit at all, execution stops at the beginning of the replay log.
Signed-off-by: Pavel Dovgalyuk <address@hidden>
---
cpus.c | 3 ++
exec.c | 1 +
gdbstub.c | 10 ++++++-
include/sysemu/replay.h | 6 ++++
replay/replay-debugging.c | 69 +++++++++++++++++++++++++++++++++++++++++++++
stubs/replay.c | 5 +++
6 files changed, 93 insertions(+), 1 deletion(-)
diff --git a/cpus.c b/cpus.c
index 5189a7e..8c0d7c4 100644
--- a/cpus.c
+++ b/cpus.c
@@ -1110,6 +1110,9 @@ static void cpu_handle_guest_debug(CPUState *cpu)
cpu->stopped = true;
} else {
if (!cpu->singlestep_enabled) {
+ /* Report about the breakpoint and
+ make a single step to skip it */
+ replay_breakpoint();
cpu_single_step(cpu, SSTEP_ENABLE);
} else {
cpu_single_step(cpu, 0);
diff --git a/exec.c b/exec.c
index 7e794cb..879b51b 100644
--- a/exec.c
+++ b/exec.c
@@ -2741,6 +2741,7 @@ static void check_watchpoint(int offset, int len,
MemTxAttrs attrs, int flags)
if (replay_running_debug()) {
/* Don't process the watchpoints when we are
in a reverse debugging operation. */
+ replay_breakpoint();
return;
}
if (flags == BP_MEM_READ) {
diff --git a/gdbstub.c b/gdbstub.c
index 6af98998..b17bbe5 100644
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -1111,6 +1111,14 @@ static int gdb_handle_packet(GDBState *s, const char
*line_buf)
put_packet(s, "E14");
break;
}
+ case 'c':
+ if (replay_reverse_continue()) {
+ gdb_continue(s);
+ return RS_IDLE;
+ } else {
+ put_packet(s, "E14");
+ break;
+ }
default:
goto unknown_command;
}
@@ -1381,7 +1389,7 @@ static int gdb_handle_packet(GDBState *s, const char
*line_buf)
pstrcat(buf, sizeof(buf), ";qXfer:features:read+");
}
if (replay_mode == REPLAY_MODE_PLAY) {
- pstrcat(buf, sizeof(buf), ";ReverseStep+");
+ pstrcat(buf, sizeof(buf), ";ReverseStep+;ReverseContinue+");
}
put_packet(s, buf);
break;
diff --git a/include/sysemu/replay.h b/include/sysemu/replay.h
index 73bf5fc..05cb40a 100644
--- a/include/sysemu/replay.h
+++ b/include/sysemu/replay.h
@@ -77,9 +77,15 @@ const char *replay_get_filename(void);
Used by gdbstub for backwards debugging.
Returns true on success. */
bool replay_reverse_step(void);
+/* Start searching the last breakpoint/watchpoint.
+ Used by gdbstub for backwards debugging.
+ Returns true if the process successfully started. */
+bool replay_reverse_continue(void);
/* Returns true if replay module is processing
reverse_continue or reverse_step request */
bool replay_running_debug(void);
+/* Called in reverse debugging mode to collect breakpoint information */
+void replay_breakpoint(void);
/* Processing the instructions */
diff --git a/replay/replay-debugging.c b/replay/replay-debugging.c
index 6334d82..b43a008 100644
--- a/replay/replay-debugging.c
+++ b/replay/replay-debugging.c
@@ -22,6 +22,8 @@
#include "migration/snapshot.h"
static bool replay_is_debugging;
+static int64_t replay_last_breakpoint;
+static int64_t replay_last_snapshot;
bool replay_running_debug(void)
{
@@ -248,3 +250,70 @@ bool replay_reverse_step(void)
return false;
}
+
+static void replay_continue_end(void)
+{
+ replay_is_debugging = false;
+ vm_stop(RUN_STATE_DEBUG);
+ replay_break(-1LL, NULL, NULL);
+}
+
+static void replay_continue_stop(void *opaque)
+{
+ Error *err = NULL;
+ if (replay_last_breakpoint != -1LL) {
+ replay_seek(replay_last_breakpoint, replay_stop_vm_debug, &err);
+ if (err) {
+ error_free(err);
+ replay_continue_end();
+ }
+ return;
+ }
+ /* No breakpoints since the last snapshot.
+ Find previous snapshot and try again. */
+ if (replay_last_snapshot != 0) {
+ replay_seek(replay_last_snapshot - 1, replay_continue_stop, &err);
+ if (err) {
+ error_free(err);
+ replay_continue_end();
+ }
+ replay_last_snapshot = replay_get_current_step();
+ return;
+ } else {
+ /* Seek to the very first step */
+ replay_seek(0, replay_stop_vm_debug, &err);
+ if (err) {
+ error_free(err);
+ replay_continue_end();
+ }
+ return;
+ }
+ replay_continue_end();
+}
+
+bool replay_reverse_continue(void)
+{
+ Error *err = NULL;
+
+ assert(replay_mode == REPLAY_MODE_PLAY);
+
+ if (replay_get_current_step() != 0) {
+ replay_seek(replay_get_current_step() - 1, replay_continue_stop, &err);
+ if (err) {
+ error_free(err);
+ return false;
+ }
+ replay_last_breakpoint = -1LL;
+ replay_is_debugging = true;
+ replay_last_snapshot = replay_get_current_step();
+ return true;
+ }
+
+ return false;
+}
+
+void replay_breakpoint(void)
+{
+ assert(replay_mode == REPLAY_MODE_PLAY);
+ replay_last_breakpoint = replay_get_current_step();
+}
diff --git a/stubs/replay.c b/stubs/replay.c
index 521552f..ee64972 100644
--- a/stubs/replay.c
+++ b/stubs/replay.c
@@ -85,3 +85,8 @@ bool replay_reverse_step(void)
{
return false;
}
+
+bool replay_reverse_continue(void)
+{
+ return false;
+}
- [Qemu-devel] [PATCH v7 05/19] replay: finish record/replay before closing the disks, (continued)
- [Qemu-devel] [PATCH v7 05/19] replay: finish record/replay before closing the disks, Pavel Dovgalyuk, 2018/10/10
- [Qemu-devel] [PATCH v7 06/19] qcow2: introduce icount field for snapshots, Pavel Dovgalyuk, 2018/10/10
- [Qemu-devel] [PATCH v7 07/19] migration: introduce icount field for snapshots, Pavel Dovgalyuk, 2018/10/10
- [Qemu-devel] [PATCH v7 08/19] replay: provide and accessor for rr filename, Pavel Dovgalyuk, 2018/10/10
- [Qemu-devel] [PATCH v7 09/19] replay: introduce info hmp/qmp command, Pavel Dovgalyuk, 2018/10/10
- [Qemu-devel] [PATCH v7 11/19] replay: implement replay-seek command to proceed to the desired step, Pavel Dovgalyuk, 2018/10/10
- [Qemu-devel] [PATCH v7 12/19] replay: refine replay-time module, Pavel Dovgalyuk, 2018/10/10
- [Qemu-devel] [PATCH v7 13/19] replay: flush rr queue before loading the vmstate, Pavel Dovgalyuk, 2018/10/10
- [Qemu-devel] [PATCH v7 10/19] replay: introduce breakpoint at the specified step, Pavel Dovgalyuk, 2018/10/10
- [Qemu-devel] [PATCH v7 14/19] gdbstub: add reverse step support in replay mode, Pavel Dovgalyuk, 2018/10/10
- [Qemu-devel] [PATCH v7 15/19] gdbstub: add reverse continue support in replay mode,
Pavel Dovgalyuk <=
- [Qemu-devel] [PATCH v7 16/19] replay: describe reverse debugging in docs/replay.txt, Pavel Dovgalyuk, 2018/10/10
- [Qemu-devel] [PATCH v7 17/19] replay: add BH oneshot event for block layer, Pavel Dovgalyuk, 2018/10/10
- [Qemu-devel] [PATCH v7 18/19] replay: init rtc after enabling the replay, Pavel Dovgalyuk, 2018/10/10
- [Qemu-devel] [PATCH v7 19/19] replay: document development rules, Pavel Dovgalyuk, 2018/10/10
- Re: [Qemu-devel] [PATCH v7 00/19] Fixing record/replay and adding reverse debugging, Aleksandr Bezzubikov, 2018/10/10
- Re: [Qemu-devel] [PATCH v7 00/19] Fixing record/replay and adding reverse debugging, Pavel Dovgalyuk, 2018/10/15