[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 1/6] target/alpha: remove tlb_flush from alph
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [PATCH v5 1/6] target/alpha: remove tlb_flush from alpha_cpu_initfn |
Date: |
Tue, 09 Oct 2018 19:14:10 +0100 |
User-agent: |
mu4e 1.1.0; emacs 26.1.50 |
Emilio G. Cota <address@hidden> writes:
> As far as I can tell tlb_flush does not need to be called
> this early. tlb_flush is eventually called after the CPU
> has been realized.
>
> This change paves the way to the introduction of tlb_init,
> which will be called from cpu_exec_realizefn.
>
> Signed-off-by: Emilio G. Cota <address@hidden>
> ---
> target/alpha/cpu.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/target/alpha/cpu.c b/target/alpha/cpu.c
> index b08078e7fc..a953897fcc 100644
> --- a/target/alpha/cpu.c
> +++ b/target/alpha/cpu.c
> @@ -201,7 +201,6 @@ static void alpha_cpu_initfn(Object *obj)
> CPUAlphaState *env = &cpu->env;
>
> cs->env_ptr = env;
> - tlb_flush(cs);
>
> env->lock_addr = -1;
> #if defined(CONFIG_USER_ONLY)
Reviewed-by: Alex Bennée <address@hidden>
--
Alex Bennée
[Qemu-devel] [PATCH v5 6/6] cputlb: read CPUTLBEntry.addr_write atomically, Emilio G. Cota, 2018/10/09
[Qemu-devel] [PATCH v5 2/6] target/unicore32: remove tlb_flush from uc32_init_fn, Emilio G. Cota, 2018/10/09
[Qemu-devel] [PATCH v5 5/6] cputlb: serialize tlb updates with env->tlb_lock, Emilio G. Cota, 2018/10/09
[Qemu-devel] [PATCH v5 3/6] exec: introduce tlb_init, Emilio G. Cota, 2018/10/09
[Qemu-devel] [PATCH v5 4/6] cputlb: fix assert_cpu_is_self macro, Emilio G. Cota, 2018/10/09
Re: [Qemu-devel] [PATCH v5 0/6] per-TLB lock, Richard Henderson, 2018/10/11