[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 0/3] Bootstrap Python venv and acceptance/functio
From: |
Cleber Rosa |
Subject: |
[Qemu-devel] [PATCH v3 0/3] Bootstrap Python venv and acceptance/functional tests |
Date: |
Tue, 9 Oct 2018 13:57:37 -0400 |
TL;DR
=====
Allow acceptance tests to be run with `make check-acceptance`.
Details
=======
This introduces a Python virtual environment that will be setup within
the QEMU build directory, that will contain the exact environment that
tests may require.
There's one current caveat: it requires Python 3, as it's based on the
venv module. This was based on some discussions and perception about
standardizing on Python 3, but can easily be made to accommodate Python
2 as well.
Changes from v2:
================
* Make the $(TESTS_VENV_DIR) target depend on the
venv-requirements.txt file, and touch $(TESTS_VENV_DIR) after venv
runs. With this, updates on the file are reflected on the
venv. (Philippe)
* Run pip with "python -m pip". It may have been installed reusing
the system wide packages, and then the script may not be available
on the venv. (Philippe)
* Dropped Python version on Travis, and using the version supplied
by the distro (3.4). (Philippe)
* Added "python3.4-venv" package requirement on Travis. (Philippe)
* Travis jobs have been sucesfully executed with this approach:
https://travis-ci.org/philmd/qemu/jobs/439254826
* Added variable (AVOCADO_SHOW) with logging streams to be shown
while running the acceptance tests. By default it's set to none,
the equivalent of the quiet mode used on previous versions.
(Philippe)
* On Travis, set the AVOCADO_SHOW variable to "app", so that the
individual test results can be easily seen. (Philippe)
Ideas discussed, but not implemented:
* Run pip with "$(PYTHON) -m pip -q install ..." because it points
to the system wide Python installation. (Philippe)
* Drop the "--system-site-packages" flag. Waiting on another round
of tests to determine if they are really the cause of some package
installation problems.
Changes from v1:
================
* TESTS_VENV_REQ (the path of "venv-requirements.txt") now points to
the source path ($SRC_PATH instead of $BUILD_DIR)
* Create the venv with "--system-site-packages", which allows the
reuse of packages (and no additional downloads) in case there's a
package installed system wide providing the same package and
version.
* Run Avocado with "python -m avocado". It may have been installed
reusing the system wide packages, and then the script may not
be available on the venv.
* Improved documentation describing the Python 3, venv and pip
requirements.
* Updated avocado-framework requirement to latest released version
(65.0)
* (New commit) Added support for running the acceptance tests on
Travis.
Ideas discussed, but not implemented:
* Install external packages such as python3-pip on Debian based
systems, deemed too invasive on developer's systems.
* Allow the use of Python 2, and consequently the "virtualenv"
module.
Cleber Rosa (3):
Bootstrap Python venv for tests
Acceptance tests: add make rule for running them
Travis support for the acceptance tests
.travis.yml | 5 +++++
docs/devel/testing.rst | 35 ++++++++++++++++++++++++++++++-----
tests/Makefile.include | 37 +++++++++++++++++++++++++++++++++++++
tests/venv-requirements.txt | 4 ++++
4 files changed, 76 insertions(+), 5 deletions(-)
create mode 100644 tests/venv-requirements.txt
--
2.17.1
- [Qemu-devel] [PATCH v3 0/3] Bootstrap Python venv and acceptance/functional tests,
Cleber Rosa <=