[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/2] docs: Document vCPU hotplug procedure
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [PATCH v2 2/2] docs: Document vCPU hotplug procedure |
Date: |
Tue, 9 Oct 2018 11:59:17 +0200 |
On Mon, 8 Oct 2018 14:10:50 -0500
Eric Blake <address@hidden> wrote:
> On 10/1/18 3:59 AM, Igor Mammedov wrote:
>
> >>> Anyway, what about this:
> >>>
> >>> The command returns an object with a "qom-path" member for each
> >>> present CPU. In this case, it shows an IvyBridge-IBRS-x86_64-cpu in
> >>> socket 0.
> >>>
> >>> It returns an object without a "qom-path" for every possibly CPU
> >>> hot-plug. In this case, it shows you can plug an
> >>> IvyBridge-IBRS-x86_64-cpu into socket 1, and the additional
> >>> properties you need to pass to device_add for that.
> > not really sure my English (CCed Eric) but to match 'an object' with
> > the rest of sentence:
> >
> > It returns an object without a "qom-path" for a possible to hot-plug CPU.
> > +
> > In this case, it shows you can plug an IvyBridge-IBRS-x86_64-cpu
> > into socket 1/core = 0/thread 0, where 'props' list describes
> > additional properties you need to pass to device_add for hot-pluging
> > that CPU.
>
> Maybe:
>
> The command returns an object for CPUs that are present (containing a
> "qom-path" member) or which may be hot-plugged (no "qom-path" member).
> In this example, an IvyBridge-IBRS-x86_64-cpu is present in socket 0,
> while hot-plugging a CPU into socket 1 requires passing the listed
> properties to device_add.
to be precise it's a logical cpu in socket/core/thread, but considering
example has only 2 socket and 2 cpus total, suggested variant probably
is good too.