[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/2] Deprecate QMP `cpu-add`
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 1/2] Deprecate QMP `cpu-add` |
|
Date: |
Mon, 08 Oct 2018 15:29:10 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Kashyap Chamarthy <address@hidden> writes:
> On Mon, Oct 01, 2018 at 11:28:17AM +0200, Thomas Huth wrote:
>> On 2018-09-25 18:02, Kashyap Chamarthy wrote:
>
> [...]
>
>> > +++ b/qapi/misc.json
>> > @@ -1104,7 +1104,11 @@
>> > ##
>> > # @cpu-add:
>> > #
>> > -# Adds CPU with specified ID
>> > +# Adds CPU with specified ID.
>> > +#
>> > +# Notes: This command is deprecated. The `device_add` command should be
>>
>> s/Notes/Note/ ?
>
> Yeah, first I wrote the singular. But went with plural as I saw it as
> it was the 'majority' pattern:
>
> $> git grep "Note:" qapi/misc.json | wc -l
> 13
> $> git grep "Notes:" qapi/misc.json | wc -l
> 18
Not exactly overwhelming majority :)
> Maybe people use the plural, "Notes", as they can add multiple entries.
For what it's worth, our doc generator recognizes both.
[...]