Re: [Qemu-devel] [PATCH v4 10/10] qmp: common 'id' handling & make QGA conform to QMP spec

[Markus Armbruster]

Marc-André Lureau <address@hidden> writes:

> Hi
>
> On Sat, Sep 1, 2018 at 4:06 PM Marc-André Lureau
> <address@hidden> wrote:
>>
>> On Sat, Sep 1, 2018 at 12:59 PM, Markus Armbruster <address@hidden> wrote:
>> > Marc-André Lureau <address@hidden> writes:
>> >
>> >> Let qmp_dispatch() copy the 'id' field. That way any qmp client will
>> >> conform to the specification, including QGA. Furthermore, it
>> >> simplifies the work for qemu monitor.
>> >>
>> >> Signed-off-by: Marc-André Lureau <address@hidden>
>> >> Reviewed-by: Markus Armbruster <address@hidden>
>> >> Reviewed-by: Michael Roth <address@hidden>
>> >> ---
>> >>  monitor.c           | 33 ++++++++++++---------------------
>> >>  qapi/qmp-dispatch.c | 10 ++++++++--
>> >>  tests/test-qga.c    | 13 +++++--------
>> >>  3 files changed, 25 insertions(+), 31 deletions(-)
>> >
>> > Let's squash in
>> >
>> > diff --git a/docs/interop/qmp-spec.txt b/docs/interop/qmp-spec.txt
>> > index 8f7da0245d..5fdfb2a4d0 100644
>> > --- a/docs/interop/qmp-spec.txt
>> > +++ b/docs/interop/qmp-spec.txt
>> > @@ -109,6 +109,7 @@ or
>> >    command execution, it is optional and will be part of the response
>> >    if provided.  The "id" member can be any json-value.  A json-number
>> >    incremented for each successive command works fine.
>> > +- Older versions of the QEMU Guest agent do not support "id".
>>
>> Good idea. Are you taking and updating the patch, or Michael?
>>
>
> any of you taking the patch?

Quoting myself (Message-ID: <address@hidden>):

    I left the QGA stuff out of my "[PULL 0/6] Monitor patches for
    2018-09-01".  If it's still pending when I do my next pull request for
    QMP stuff, I can include it.  Of course, Michael is welcome to take it
    earlier.