[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC 5/6] cpu-defs: define MIN_CPU_TLB_SIZE
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [RFC 5/6] cpu-defs: define MIN_CPU_TLB_SIZE |
Date: |
Sun, 7 Oct 2018 20:01:03 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 10/6/18 2:45 PM, Emilio G. Cota wrote:
> @@ -89,7 +89,7 @@ typedef uint64_t target_ulong;
> * 0x18 (the offset of the addend field in each TLB entry) plus the offset
> * of tlb_table inside env (which is non-trivial but not huge).
> */
> -#define CPU_TLB_BITS \
> +#define MIN_CPU_TLB_BITS \
> MIN(8, \
> TCG_TARGET_TLB_DISPLACEMENT_BITS - CPU_TLB_ENTRY_BITS - \
> (NB_MMU_MODES <= 1 ? 0 : \
There's no point in this either, since the original constraint was due to the
immediate offset into an add instruction. Now we're loading the base address
from an array. The actual size of the tlb is immaterial now, since the size of
the tlb does not affect the size of CPUArchState.
r~
- [Qemu-devel] [RFC 0/6] Dynamic TLB sizing, Emilio G. Cota, 2018/10/06
- [Qemu-devel] [RFC 4/6] tcg: define TCG_TARGET_TLB_MAX_INDEX_BITS, Emilio G. Cota, 2018/10/06
- [Qemu-devel] [RFC 3/6] cputlb: track TLB use rates, Emilio G. Cota, 2018/10/06
- [Qemu-devel] [RFC 5/6] cpu-defs: define MIN_CPU_TLB_SIZE, Emilio G. Cota, 2018/10/06
- Re: [Qemu-devel] [RFC 5/6] cpu-defs: define MIN_CPU_TLB_SIZE,
Richard Henderson <=
- [Qemu-devel] [RFC 6/6] cputlb: dynamically resize TLBs based on use rate, Emilio G. Cota, 2018/10/06
- Re: [Qemu-devel] [RFC 6/6] cputlb: dynamically resize TLBs based on use rate, Richard Henderson, 2018/10/07
- [Qemu-devel] [RFC 2/6] cputlb: do not evict invalid entries to the vtlb, Emilio G. Cota, 2018/10/06