[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/7] scripts/qemu.py: add method and private att
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH 3/7] scripts/qemu.py: add method and private attribute for arch |
Date: |
Fri, 5 Oct 2018 17:28:16 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 04/10/2018 17:14, Cleber Rosa wrote:
> Because some sane defaults may require the knowledge of the arch,
> let's give the QEMUMachine the opportunity to hold that information.
>
> Signed-off-by: Cleber Rosa <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> scripts/qemu.py | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/scripts/qemu.py b/scripts/qemu.py
> index f099ce7278..d9e24a0c1a 100644
> --- a/scripts/qemu.py
> +++ b/scripts/qemu.py
> @@ -113,6 +113,7 @@ class QEMUMachine(object):
> self._test_dir = test_dir
> self._temp_dir = None
> self._launched = False
> + self._arch = None
> self._machine = None
> self._console_device_type = None
> self._console_address = None
> @@ -406,6 +407,12 @@ class QEMUMachine(object):
> '''
> self._args.extend(args)
>
> + def set_arch(self, arch):
> + """
> + Sets the architecture of this machine
> + """
> + self._arch = arch
> +
> def set_machine(self, machine_type):
> '''
> Sets the machine type
>
- [Qemu-devel] [PATCH 0/7] Acceptance Tests: basic architecture support, Cleber Rosa, 2018/10/04
- [Qemu-devel] [PATCH 1/7] Acceptance Tests: improve docstring on pick_default_qemu_bin(), Cleber Rosa, 2018/10/04
- [Qemu-devel] [PATCH 2/7] Acceptance Tests: introduce arch parameter and attribute, Cleber Rosa, 2018/10/04
- [Qemu-devel] [PATCH 3/7] scripts/qemu.py: add method and private attribute for arch, Cleber Rosa, 2018/10/04
- Re: [Qemu-devel] [PATCH 3/7] scripts/qemu.py: add method and private attribute for arch,
Philippe Mathieu-Daudé <=
- [Qemu-devel] [PATCH 4/7] scripts/qemu.py: set predefined machine type based on arch, Cleber Rosa, 2018/10/04
- [Qemu-devel] [PATCH 5/7] Acceptance Tests: set machine type, Cleber Rosa, 2018/10/04
- [Qemu-devel] [PATCH 6/7] Acceptance Tests: add variants definition for architectures, Cleber Rosa, 2018/10/04