[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 06/10] thunk.c: clean up commented out definitio
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-devel] [PATCH 06/10] thunk.c: clean up commented out definition |
Date: |
Thu, 4 Oct 2018 18:36:51 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
Le 04/10/2018 à 18:31, Cleber Rosa a écrit :
>
>
> On 10/4/18 12:24 PM, Laurent Vivier wrote:
>> Le 04/10/2018 à 18:18, Cleber Rosa a écrit :
>>> Signed-off-by: Cleber Rosa <address@hidden>
>>> ---
>>> thunk.c | 2 --
>>> 1 file changed, 2 deletions(-)
>>>
>>> diff --git a/thunk.c b/thunk.c
>>> index d5d8645cd4..e351ae53af 100644
>>> --- a/thunk.c
>>> +++ b/thunk.c
>>> @@ -21,8 +21,6 @@
>>> #include "qemu.h"
>>> #include "exec/user/thunk.h"
>>>
>>> -//#define DEBUG
>>> -
>>
>> Generally we use that to enable easily existing debug traces.
>>
>
> Oh, I wasn't aware that was intentional (I clearly lack some background
> here).
>
>> In this case, if you remove the "#define" I think you should also
>> replace the "#ifdef DEBUG"s by some trace_XXXX() functions.
>>
>
> Is that desirable? I don't want to disrupt the status quo just because
> it looked odd to me.
Yes, it's better to have trace_XXX() functions than DEBUG macros. The
change is trivial (add the format strings in ./trace-events and call
them from thunk.c with the existing parameters)
Thanks,
Laurent
- Re: [Qemu-devel] [PATCH 03/10] qemu-iotests: make 218 executable, (continued)
Re: [Qemu-devel] [Qemu-trivial] [PATCH 03/10] qemu-iotests: make 218 executable, Laurent Vivier, 2018/10/25
[Qemu-devel] [PATCH 05/10] docs/devel/testing.rst: add missing newlines after code block, Cleber Rosa, 2018/10/04
[Qemu-devel] [PATCH 06/10] thunk.c: clean up commented out definition, Cleber Rosa, 2018/10/04
[Qemu-devel] [PATCH 04/10] qemu-iotests: fix filename containing checks, Cleber Rosa, 2018/10/04
[Qemu-devel] [PATCH 07/10] scripts/decodetree.py: remove unused imports, Cleber Rosa, 2018/10/04
[Qemu-devel] [PATCH 08/10] scripts/decodetree.py: fix reference to attributes, Cleber Rosa, 2018/10/04
[Qemu-devel] [PATCH 09/10] scripts/qemu.py: use a more consistent docstring style, Cleber Rosa, 2018/10/04