Re: [Qemu-devel] [PATCH 6/7] qga-win: report specific error when failing to open channel

[Marc-André Lureau]

Hi

On Thu, Sep 27, 2018 at 11:42 AM Bishara AbuHattoum <address@hidden> wrote:
>
> From: Michael Roth <address@hidden>
>
> Useful in general, but especially now that errors might occur more
> frequently with --retry-path set.
>
> Signed-off-by: Michael Roth <address@hidden>
> Message-Id: <address@hidden>

without extra message-id,
Reviewed-by: Marc-André Lureau <address@hidden>

> ---
>  qga/channel-win32.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/qga/channel-win32.c b/qga/channel-win32.c
> index b3597a8a0f..c86f4388db 100644
> --- a/qga/channel-win32.c
> +++ b/qga/channel-win32.c
> @@ -302,7 +302,8 @@ static gboolean ga_channel_open(GAChannel *c, 
> GAChannelMethod method,
>                             OPEN_EXISTING,
>                             FILE_FLAG_NO_BUFFERING | FILE_FLAG_OVERLAPPED, 
> NULL);
>      if (c->handle == INVALID_HANDLE_VALUE) {
> -        g_critical("error opening path %s", newpath);
> +        g_critical("error opening path %s: %s", newpath,
> +                   g_win32_error_message(GetLastError()));
>          return false;
>      }
>
> --
> 2.17.0
>
>


--
Marc-André Lureau