Re: [Qemu-devel] [PATCH v3 10/10] block: Allow changing 'force-share' on reopen

[Kevin Wolf]

Am 26.09.2018 um 13:39 hat Alberto Garcia geschrieben:
> On Wed 26 Sep 2018 01:34:28 PM CEST, Kevin Wolf wrote:
> >> @@ -3353,6 +3370,7 @@ void bdrv_reopen_commit(BDRVReopenState 
> >> *reopen_state)
> >>      bs->open_flags         = reopen_state->flags;
> >>      bs->read_only = !(reopen_state->flags & BDRV_O_RDWR);
> >>      bs->detect_zeroes      = reopen_state->detect_zeroes;
> >> +    bs->force_share        = reopen_state->force_share;
> >
> > Just changing bs->force_share without actually triggering recalculation
> > of the permissions is kind of pointless, no? As the patch is, you would
> > have to trigger some graph change for the new setting to take effect.
> >
> > The rest of the series looks good to me, so if you like, I could apply
> > patches 1-9, and then you can either send a v4 of only this one or we'll
> > just drop it.
> 
> Apply it without this one then. Thanks!

Ok, thanks. That's what I did now.

Kevin