[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] memory: Use MAKE_64BIT_MASK()
|
From: |
Cédric Le Goater |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/3] memory: Use MAKE_64BIT_MASK() |
|
Date: |
Thu, 27 Sep 2018 08:29:40 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
Reviewed-by: Cédric Le Goater <address@hidden>
Thanks,
C.
On 9/27/18 2:24 AM, Philippe Mathieu-Daudé wrote:
> Suggested-by: Paolo Bonzini <address@hidden>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> memory.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/memory.c b/memory.c
> index 9b73892768..385b9d3590 100644
> --- a/memory.c
> +++ b/memory.c
> @@ -582,7 +582,7 @@ static MemTxResult access_with_adjusted_size(hwaddr addr,
>
> /* FIXME: support unaligned access? */
> access_size = MAX(MIN(size, access_size_max), access_size_min);
> - access_mask = -1ULL >> (64 - access_size * 8);
> + access_mask = MAKE_64BIT_MASK(0, access_size * 8);
> if (memory_region_big_endian(mr)) {
> for (i = 0; i < size; i += access_size) {
> r |= access_fn(mr, addr + i, value, access_size,
>