[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v11 7/9] qcow2: Resize the cache upon image resi
|
From: |
Leonid Bloch |
|
Subject: |
Re: [Qemu-devel] [PATCH v11 7/9] qcow2: Resize the cache upon image resizing |
|
Date: |
Wed, 26 Sep 2018 14:21:21 +0000 |
Oops, sorry. Would something like that be OK:
On 9/26/18 1:55 PM, Alberto Garcia wrote:
> On Wed 26 Sep 2018 12:43:03 PM CEST, Kevin Wolf wrote:
>>> + /* Update cache sizes */
>>> + options = qdict_clone_shallow(bs->options);
>>> + ret = qcow2_update_options(bs, options, s->flags, errp);
+ qobject_unref(options);
>>> + if (ret < 0) {
>>> + goto fail;
>>> + }
>>
Leonid.
>> Isn't options leaked, both in success and error cases?
>
> I'm embarrassed not to have seen that :-!
>
> Berto
>
[Qemu-devel] [PATCH v11 8/9] qcow2: Set the default cache-clean-interval to 10 minutes, Leonid Bloch, 2018/09/24
[Qemu-devel] [PATCH v11 9/9] qcow2: Explicit number replaced by a constant, Leonid Bloch, 2018/09/24
[Qemu-devel] [PATCH v11 6/9] qcow2: Increase the default upper limit on the L2 cache size, Leonid Bloch, 2018/09/24
[Qemu-devel] [PATCH v11 4/9] qcow2: Avoid duplication in setting the refcount cache size, Leonid Bloch, 2018/09/24
[Qemu-devel] [PATCH v11 5/9] qcow2: Assign the L2 cache relatively to the image size, Leonid Bloch, 2018/09/24
[Qemu-devel] [PATCH v11 3/9] qcow2: Make sizes more humanly readable, Leonid Bloch, 2018/09/24
[Qemu-devel] [PATCH v11 2/9] include: Add a lookup table of sizes, Leonid Bloch, 2018/09/24
[Qemu-devel] [PATCH v11 1/9] qcow2: Options' documentation fixes, Leonid Bloch, 2018/09/24