Re: [Qemu-devel] [PATCH rebased 2/2] monitor: delay monitor iothread creation

[Peter Xu]

On Tue, Sep 25, 2018 at 10:15:07AM +0200, Wolfgang Bumiller wrote:
> Commit d32749deb615 moved the call to monitor_init_globals()
> to before os_daemonize(), making it an unsuitable place to
> spawn the monitor iothread as it won't be inherited over the
> fork() in os_daemonize().
> 
> We now spawn the thread the first time we instantiate a
> monitor which actually has use_io_thread == true.
> Instantiation of monitors happens only after os_daemonize().
> We still need to create the qmp_dispatcher_bh when not using
> iothreads, so this now still happens in
> monitor_init_globals().
> 
> Signed-off-by: Wolfgang Bumiller <address@hidden>
> Fixes: d32749deb615 ("monitor: move init global earlier")

Reviewed-by: Peter Xu <address@hidden>
Tested-by: Peter Xu <address@hidden>

Though note that after this patch monitor_data_init() is not thread
safe any more (while it was), so we may need to be careful...

Thanks,

-- 
Peter Xu