[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/3] linux-user: implement special usbfs ioctls.
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-devel] [PATCH 3/3] linux-user: implement special usbfs ioctls. |
Date: |
Mon, 24 Sep 2018 18:57:54 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
Le 19/09/2018 à 10:04, Cortland Tölva a écrit :
> Userspace submits a USB Request Buffer to the kernel, optionally
> discards it, and finally reaps the URB. Thunk buffers from target
> to host and back.
>
> Tested by running an i386 scanner driver on ARMv7. Neither the
> discardurb ioctl nor the kernel's updating the argument to the
> reap ioctl with a pointer to a reaped URB are exercised by this.
>
> Signed-off-by: Cortland Tölva <address@hidden>
> ---
> linux-user/ioctls.h | 9 +++
> linux-user/syscall.c | 168
> +++++++++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 177 insertions(+)
>
It looks good (for what I understand of usbdevfs...), please move the
usbdevfs_urb parts from PATCH 2 to this one.
Reviewed-by: Laurent Vivier <address@hidden>
Thanks,
LAurent