[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] hw/timer/cmsdk-apb-dualtimer: Add missing 'break' s
From: |
Peter Maydell |
Subject: |
[Qemu-devel] [PATCH] hw/timer/cmsdk-apb-dualtimer: Add missing 'break' statements |
Date: |
Mon, 24 Sep 2018 13:31:22 +0100 |
Add 'break' statements missing from a switch in the APB dual-timer
write function. Spotted by Coverity as CID 1395626 and 1395633.
Reported-by: Paolo Bonzini <address@hidden>
Signed-off-by: Peter Maydell <address@hidden>
---
hw/timer/cmsdk-apb-dualtimer.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/timer/cmsdk-apb-dualtimer.c b/hw/timer/cmsdk-apb-dualtimer.c
index ccd49753b7f..30245990f34 100644
--- a/hw/timer/cmsdk-apb-dualtimer.c
+++ b/hw/timer/cmsdk-apb-dualtimer.c
@@ -296,9 +296,11 @@ static void cmsdk_apb_dualtimer_write(void *opaque, hwaddr
offset,
case A_TIMERITCR:
s->timeritcr = value & R_TIMERITCR_VALID_MASK;
cmsdk_apb_dualtimer_update(s);
+ break;
case A_TIMERITOP:
s->timeritop = value & R_TIMERITOP_VALID_MASK;
cmsdk_apb_dualtimer_update(s);
+ break;
default:
bad_offset:
qemu_log_mask(LOG_GUEST_ERROR,
--
2.19.0
- [Qemu-devel] [PATCH] hw/timer/cmsdk-apb-dualtimer: Add missing 'break' statements,
Peter Maydell <=