|
From: | Alberto Garcia |
Subject: | Re: [Qemu-devel] [PATCH] block: Don't call update_flags_from_options() if the options are wrong |
Date: | Wed, 19 Sep 2018 17:07:37 +0200 |
User-agent: | Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Tue 11 Sep 2018 02:32:56 PM CEST, Alberto Garcia wrote: > If qemu_opts_absorb_qdict() fails and we carry on and call > update_flags_from_options() then that can result on a failed > assertion: > > $ qemu-io -c 'reopen -o read-only=foo' hd.qcow2 > block.c:1101: update_flags_from_options: Assertion `qemu_opt_find(opts, > BDRV_OPT_CACHE_DIRECT)' failed. > Aborted This patch is now part of the "Don't pass flags to bdrv_reopen_queue()" series: https://lists.gnu.org/archive/html/qemu-block/2018-09/msg00483.html Berto
[Prev in Thread] | Current Thread | [Next in Thread] |