Re: [Qemu-devel] [PATCH 1/3] Improve xen_disk batching behaviour

[Anthony PERARD]

Hi Tim,

I'll reply here for the series (since there are no cover-letter).

Thanks, the patches looks good. There are just details that needs to be
fixed.

When resubmitting the patches, could you CC the relevant maintainers,
with the help of the script get_maintainer.pl, and add a cover-letter as
it is used for automatic checking. You can find more information here:
https://wiki.qemu.org/Contribute/SubmitAPatch#Submitting_your_Patches

The patches have a few coding style issue listed below, can you fix
them and resend the patches? Thanks.


$ ./scripts/checkpatch.pl 000*
WARNING: line over 80 characters
#62: FILE: hw/block/xen_disk.c:607:
+        if (inflight_atstart > IO_PLUG_THRESHOLD && batched >= 
inflight_atstart) {

ERROR: spaces required around that '=' (ctx:VxV)
#69: FILE: hw/block/xen_disk.c:614:
+                batched=0;
                        ^

total: 1 errors, 1 warnings, 54 lines checked

0001-Improve-xen_disk-batching-behaviour.patch has style problems, please 
review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
total: 0 errors, 0 warnings, 111 lines checked

0002-Improve-xen_disk-response-latency.patch has no obvious style problems and 
is ready for submission.
WARNING: line over 80 characters
#38: FILE: hw/block/xen_disk.c:139:
+        /* We cannot need more pages per ioreq than this, and we do re-use 
ioreqs,

ERROR: line over 90 characters
#41: FILE: hw/block/xen_disk.c:142:
+        ioreq->buf = qemu_memalign(XC_PAGE_SIZE, 
BLKIF_MAX_SEGMENTS_PER_REQUEST * XC_PAGE_SIZE);

total: 1 errors, 1 warnings, 50 lines checked

0003-Avoid-repeated-memory-allocation-in-xen_disk.patch has style problems, 
please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.


Cheers,

-- 
Anthony PERARD