|
From: | Eric Blake |
Subject: | Re: [Qemu-devel] [PATCH V12-fix 01/19] filter-rewriter: Add TCP state machine and fix memory leak in connection_track_table |
Date: | Thu, 13 Sep 2018 09:49:03 -0500 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 9/12/18 11:52 PM, Zhang Chen wrote:
We add almost full TCP state machine in filter-rewriter, except TCPS_LISTEN and some simplify in VM active close FIN states. The reason for this simplify job is because guest kernel will track the TCP status and wait 2MSL time too, if client resend the FIN packet, guest will resend the last ACK, so we needn't wait 2MSL time in filter-rewriter. After a net connection is closed, we didn't clear its releated resources
s/releated/related/
in connection_track_table, which will lead to memory leak. Let't track the state of net connection, if it is closed, its related
s/Let't/Let's/
resources will be cleared up. Signed-off-by: zhanghailiang <address@hidden> Signed-off-by: Zhang Chen <address@hidden> Signed-off-by: Zhang Chen <address@hidden>
Should both of these last two S-o-b be present? -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
[Prev in Thread] | Current Thread | [Next in Thread] |