Re: [Qemu-devel] [qemu-s390x] [RFC 08/15] s390-bios: Map low core memory

[Jason J. Herne]

On 09/13/2018 01:25 AM, Thomas Huth wrote:
> On 2018-09-10 16:17, Jason J. Herne wrote:
> > On 07/17/2018 02:10 PM, Thomas Huth wrote:
> > > On 05.07.2018 19:25, Jason J. Herne wrote:
> > > > From: "Jason J. Herne" <address@hidden>
...
> > > The names of the fields look exactly the same as in the Linux kernel ...
> > > maybe credit them at least in the patch description?
> >
> > Due to some internal issues and bug hunting this has been on the back
> > burner for a while. Getting back into it now...
> >
> > I took lowcore from Qemu code, not the kernel. target/s390x/internal.h.
>
> Ok, fair, then never mind.
>
> Just another thought: We've got a couple of structs and defines already
> that we share between the s390-ccw bios and the "normal" QEMU code ...
> maybe we should define a common set of headers that could be used by
> both parts? And put these in includes/hw/s390x/ and let the s390-ccw
> bios code include headers from that folder, too? Or would that be too
> confusing and we better should keep everything separated (and duplicated)?
>
>   Thomas

I originally thought the same thing. But the issue is that we already 
duplicate a fair amount code and headers from Qemu for the bios. SCLP, 
most i/o routines, some basic machine level stuff, etc. I'd like to see 
a cleanup effort to consolidate this code, but I feel like it would be 
far too much for this patch set.

--
-- Jason J. Herne (address@hidden)