qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v6 20/25] replay: wake up vCPU when replaying


From: Pavel Dovgalyuk
Subject: Re: [Qemu-devel] [PATCH v6 20/25] replay: wake up vCPU when replaying
Date: Thu, 13 Sep 2018 14:06:28 +0300

> From: Paolo Bonzini [mailto:address@hidden
> On 12/09/2018 10:19, Pavel Dovgalyuk wrote:
> > This patch tries to wake up the vCPU when it sleeps and the icount warp
> > checkpoint isn't met. It means that vCPU has something to do, because
> > there are no other reasons of non-matching warp checkpoint.
> 
> What happens if !replay_has_checkpoint()?  Should that be an assertion?

The condition may be true, only when vCPU thread is sleeping.
In all other cases (e.g., running) the condition is false and we
have nothing to do.

Pavel Dovgalyuk




reply via email to

[Prev in Thread] Current Thread [Next in Thread]