Re: [Qemu-devel] [PATCH V12 19/19] docs: Add COLO status diagram to COLO-FT.txt

[Jason Wang]

On 2018年09月03日 12:39, Zhang Chen wrote:
> From: Zhang Chen <address@hidden>
>
> This diagram make user better understand COLO.
> Suggested by Markus Armbruster.
>
> Signed-off-by: Zhang Chen <address@hidden>
> Signed-off-by: Zhang Chen <address@hidden>
> ---
>   docs/COLO-FT.txt | 34 ++++++++++++++++++++++++++++++++++
>   1 file changed, 34 insertions(+)
>
> diff --git a/docs/COLO-FT.txt b/docs/COLO-FT.txt
> index d7c7dcda8f..d5007895d1 100644
> --- a/docs/COLO-FT.txt
> +++ b/docs/COLO-FT.txt
> @@ -110,6 +110,40 @@ Note:
>   HeartBeat has not been implemented yet, so you need to trigger failover 
> process
>   by using 'x-colo-lost-heartbeat' command.
>   
> +== COLO operation status ==
> +
> ++-----------------+
> +|                 |
> +|    Start COLO   |
> +|                 |
> ++--------+--------+
> +         |
> +         |  Main qmp command:
> +         |  migrate-set-capabilities with x-colo
> +         |  migrate
> +         |
> +         v
> ++--------+--------+
> +|                 |
> +|  COLO running   |
> +|                 |
> ++--------+--------+
> +         |
> +         |  Main qmp command:
> +         |  x-colo-lost-heartbeat
> +         |  or
> +         |  some error happened
> +         v
> ++--------+--------+
> +|                 |  send qmp event:
> +|  COLO failover  |  COLO_EXIT
> +|                 |
> ++-----------------+
> +
> +COLO use the qmp command switching and report operation status.

It looks to me that "to switch" is better.

> +The diagram just write the main qmp command, you can get the detail
> +in test procedure.

s/write/shows/

I will fix this patch directly.

Thanks

> +
>   == Test procedure ==
>   1. Startup qemu
>   Primary: