Re: [Qemu-devel] [RFC PATCH 3/4] linux-user/nios2: bump min uname to 4.16.0 [!HACK]

[Marek Vasut]

On 09/11/2018 05:08 PM, Alex Bennée wrote:
> 
> Marek Vasut <address@hidden> writes:
> 
>> On 09/11/2018 04:14 PM, Laurent Vivier wrote:
>>> Le 11/09/2018 à 16:06, Alex Bennée a écrit:
>>>> This is to work around the limitations of the buildroot
>>>> qemu_nios2_10m50_defconfig which sets the base kernel version for
>>>> glibc.
>>>>
>>>> Signed-off-by: Alex Bennée <address@hidden>
>>>> ---
>>>>  linux-user/nios2/target_syscall.h | 2 +-
>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/linux-user/nios2/target_syscall.h 
>>>> b/linux-user/nios2/target_syscall.h
>>>> index ca6b7e69f6..905b80d112 100644
>>>> --- a/linux-user/nios2/target_syscall.h
>>>> +++ b/linux-user/nios2/target_syscall.h
>>>> @@ -2,7 +2,7 @@
>>>>  #define TARGET_SYSCALL_H
>>>>
>>>>  #define UNAME_MACHINE "nios2"
>>>> -#define UNAME_MINIMUM_RELEASE "3.19.0"
>>>> +#define UNAME_MINIMUM_RELEASE "4.16.0"
>>>>
>>>>  struct target_pt_regs {
>>>>      unsigned long  r8;    /* r8-r15 Caller-saved GP registers */
>>>>
>>>
>>> I have no objection. Perhaps you could ask NiosII Maintainers (cc).
>>
>> If that's needed, so be it. The Linux 3.19 was required because some
>> obscure ABI change happened at that point.
> 
> I don't think so - it's an artefact of the way the buildroot toolchain
> is built. But the real question which I address in the cover letter is
> does nios2-linux-user get much use? I tried enabled tests/tcg for it and
> it fails rather badly.

I used it around 2.10 and it worked for me.

-- 
Best regards,
Marek Vasut